With delay #34
Open
With delay #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 2, 2019 11:35
nirsky
reviewed
Apr 3, 2019
| @@ -295,4 +295,23 @@ describe('Route Matching - willReturn', () => { | |||
| expect(fakeServer.hasMade(route.call.withPath(actualPath).withBodyText(actualBody))).toEqual(true); | |||
| expect(fakeServer.hasMade(route.call.withBodyText(actualBody).withPath(actualPath))).toEqual(true); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Add some tests for multiple restrictions now that it's supported?
| @@ -55,6 +55,7 @@ const route = fakeServer.http | |||
| .get() // Http Method (mandatory). See Supported HTTP Methods section. | |||
| .to(pathRegex) // Route Path (mandatory). May be regex | |||
| .withBody(object) // Route Restriction (optional). See Route Restrictions section. | |||
| .withDelay(ms) // Delay response in ms (optional) | |||
There was a problem hiding this comment.
not related to this line, but please update the Route Restrictions section that several restrictions are now supported.
nirsky
approved these changes
Apr 3, 2019
added 2 commits
June 6, 2020 21:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add The ability to delay a response to fake latency over the network.
Resolves #1