Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/add-guide-under-development-info #262

Closed
wkrzos opened this issue Oct 1, 2024 · 15 comments · Fixed by #281
Closed

feat/add-guide-under-development-info #262

wkrzos opened this issue Oct 1, 2024 · 15 comments · Fixed by #281
Assignees
Labels
enhancement New feature or request PM pm stuff, not `dev` or `design` related

Comments

@wkrzos
Copy link
Member

wkrzos commented Oct 1, 2024

Image

@wkrzos wkrzos added enhancement New feature or request PM pm stuff, not `dev` or `design` related labels Oct 1, 2024
@wkrzos wkrzos added this to the v1.1.0 milestone Oct 1, 2024
@wkrzos wkrzos moved this to Todo in ToPWR Oct 1, 2024
@wkrzos wkrzos added this to ToPWR Oct 1, 2024
@simon-the-shark
Copy link
Member

here also we need some design proposition first (I'm not sure if this will look nice)

@kamilfedio kamilfedio self-assigned this Oct 2, 2024
@kamilfedio
Copy link
Member

kamilfedio commented Oct 2, 2024

@simon-the-shark @mikolaj-jalocha

  1. First idea
image 2. Second idea image

Personally I would go for opt number 1. Is very clear, readable and easy to notice. Whats more It doesn't destroy our current design

@mikolaj-jalocha
Copy link
Member

Good work here! Imo the 1st one ;)

@kamilfedio
Copy link
Member

I just updated my comm and i think the same

@simon-the-shark
Copy link
Member

The red color is imo too agressive for this information that is not that crucial afterall

@wkrzos
Copy link
Member Author

wkrzos commented Oct 2, 2024

We could flip the colours? White box with stroke and the ToPWR-orange colour text? Worth a try. Great work on the design btw, love it!

@simon-the-shark
Copy link
Member

I would go for as greyish as possible, cause it's not that crucial. Maybe just the same colors like in a normal guide tile? But that's just my opinion. What you think @wkrzos or rest?

@simon-the-shark
Copy link
Member

But i like the concept overall

@wkrzos
Copy link
Member Author

wkrzos commented Oct 2, 2024

I agree, the info isn't that important as of now. Could we compare the option with the guide palette and one, where we use the same palette, but colour the text orange? If it isn't too much work ofc

@mikolaj-jalocha
Copy link
Member

mikolaj-jalocha commented Oct 2, 2024 via email

@kamilfedio
Copy link
Member

kamilfedio commented Oct 2, 2024

  1. version without bgc color
image 2. Default version image Later i will try with orange color but tbh it will has to much contrast

@wkrzos
Copy link
Member Author

wkrzos commented Oct 2, 2024

The first one could work, although I think that the second one looks more pleasing. Could we try the second format, but with the font in orange? I'm almost sure that it looks better in gray but I'm curious.

@wkrzos
Copy link
Member Author

wkrzos commented Oct 2, 2024

Nevermind the orange colour, just read the rest of your comment and you're right, the contrast will be too annoying XD

@kamilfedio
Copy link
Member

User experience left the chat. Im wating for rest of opinions to push pr

@simon-the-shark
Copy link
Member

Imo either the first one but with less spacing or just the second one should be fine

@simon-the-shark simon-the-shark moved this from Todo to In Progress in ToPWR Oct 2, 2024
@kamilfedio kamilfedio linked a pull request Oct 3, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in ToPWR Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PM pm stuff, not `dev` or `design` related
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants