Feat/new map solution #220
Conversation
There was a problem hiding this comment.
Good work! Substantial amount of code here've been refactored. Few notes below:
- In my opinion OSM design looks quite nice. It is very readable and for me - suits even better than previous one. But interesting and challenging task for the future (regarding creating our own design)'d nice ;)
- At least on emulator performance's been significantly improved
- I think there's need for good looking animation under the condition that it wouldn't reduce performance.
- On Android device I couldn't see the compass
- Below I posted some of my suggestion (minor ones). Treat them as suggestions, not required changes of any kind.
- Also, I've posted some questions of mine regarding current solutions
- I've created some tasks that you mentioned. Please convert them to issues, once pr's resolved ;) Currently I didn't include markers clustering, idk what are the pros and cons here. Explanation needed 😂
There was a problem hiding this comment.
Can the old animations be placed here? (The ones before changes)
There was a problem hiding this comment.
yeah but we need separate package for this to be able to animate camera, and the way it's structured, we need to do some refactor with this too: https://pub.dev/packages/flutter_map_animations
| @@ -29,7 +29,7 @@ class _NoTransitionRoute extends CustomRoute { | |||
| } | |||
|
|
|||
| @AutoRouterConfig(replaceInRouteName: "View,Route") | |||
| class AppRouter extends _$AppRouter { | |||
| class AppRouter extends RootStackRouter { | |||
There was a problem hiding this comment.
Why the change here? Just curious
There was a problem hiding this comment.
it's caused by a new version of auto_route
| ref.read(parkingsMapControllerProvider.notifier).onMarkerTap(item); | ||
| }, | ||
| alignment: Alignment.topCenter, | ||
| child: GestureDetector( |
There was a problem hiding this comment.
Looks nice. Did you think about some splash effect here? Could improve UX
There was a problem hiding this comment.
but not sure how this would look, opening up a task for the future reference
There was a problem hiding this comment.
Can compass be seen on Android?
There was a problem hiding this comment.
it's disabled when the map is straight to the north. It should pop up when you rotate the map. It can be configured otherwhise too
simon-the-shark
force-pushed
the
feat/new-map-solution
branch
from
2796809
to
35a18a0
Compare
So I did try to use flutter map package and imo it's pretty lightweight. Also it's kinda like building blocks so we can add more features later and we have very big control over what's happening there. Drawbacks to this is e.g. that we have to implement my location button ourselves.
So open street map doesn't look as cool as other providers, but is 100% free, pretty functional and if we want to use different style we can try to selfhost it at some point in the future.
potencial TODOs for the future:
tell me what you think :)
