Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#230 - replace decimal numbers with integers at parking's page & make sure that free slots are always >= 0 #231

Conversation

mikolaj-jalocha
Copy link
Member

@mikolaj-jalocha mikolaj-jalocha commented Sep 25, 2024

  • It would be perfect to notify the person reporting the error for morale support.
    Image 1

  • I’ve also implemented a mechanism that ensures that the number of available spaces is always equal to or greater than 0 (never negative, as happened on 24/09/2024).
    Image 2

@mikolaj-jalocha mikolaj-jalocha added the enhancement New feature or request label Sep 25, 2024
@mikolaj-jalocha mikolaj-jalocha added this to the v1.0.0 milestone Sep 25, 2024
@mikolaj-jalocha mikolaj-jalocha self-assigned this Sep 25, 2024
@mikolaj-jalocha mikolaj-jalocha linked an issue Sep 25, 2024 that may be closed by this pull request
@mikolaj-jalocha mikolaj-jalocha changed the title #230 - replace decimal numbers with integers at parking's page #230 - replace decimal numbers with integers at parking's page & make sure that free slots are always >= 0 Sep 25, 2024
… sure that free parking's slots're always => 0 - code cleanup
@mikolaj-jalocha mikolaj-jalocha marked this pull request as ready for review September 25, 2024 09:46
Copy link
Member

@simon-the-shark simon-the-shark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simon-the-shark simon-the-shark merged commit d824cd7 into main Sep 25, 2024
2 checks passed
@simon-the-shark simon-the-shark deleted the feat/#230-replace-decimal-numbers-with-integers-at-parkings-page branch September 25, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Replace decimal numbers with integers at parking's page
2 participants