Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change bottom padding on home view #246

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

kamilfedio
Copy link
Member

#240
I changed bottom padding on home view. Now all tabs have the same -> 24px
some ss's:
image
image
image

@@ -32,7 +32,7 @@ class HomeView extends StatelessWidget {
appBar: LogoAppBar(context),
body: KeepAliveHomeViewProviders(
child: ListView.separated(
padding: const EdgeInsets.only(bottom: 48),
padding: const EdgeInsets.only(bottom: 24),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please declare it at HomeViewConfig :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mikolaj-jalocha mikolaj-jalocha linked an issue Sep 27, 2024 that may be closed by this pull request
@mikolaj-jalocha mikolaj-jalocha added bug Something isn't working enhancement New feature or request design Design related labels Sep 27, 2024
@mikolaj-jalocha mikolaj-jalocha added this to the v1.1.0 milestone Sep 27, 2024
@mikolaj-jalocha mikolaj-jalocha merged commit 056a291 into main Sep 27, 2024
2 checks passed
@mikolaj-jalocha mikolaj-jalocha deleted the fix/unify-bottom-paddings branch September 27, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design Design related enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

fix/ unify bottom paddings among tab views
2 participants