Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat - #238 sort links on about us team #249

Closed
wants to merge 2 commits into from
Closed

feat - #238 sort links on about us team #249

wants to merge 2 commits into from

Conversation

mikolaj-jalocha
Copy link
Member

#238

  • separate sorting is now included for sci clubs and about us team
  • maybe it's good idea to make sorting not local but on backend? @Rei-x

@mikolaj-jalocha mikolaj-jalocha added bug Something isn't working enhancement New feature or request labels Sep 27, 2024
@mikolaj-jalocha mikolaj-jalocha added this to the v1.1.0 milestone Sep 27, 2024
@mikolaj-jalocha mikolaj-jalocha self-assigned this Sep 27, 2024
@mikolaj-jalocha mikolaj-jalocha linked an issue Sep 27, 2024 that may be closed by this pull request
feat/ sort links on about us team #238
Closed
simon-the-shark
simon-the-shark reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@simon-the-shark simon-the-shark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would only call this option a bit different

lib/utils/determine_contact_icon.dart Outdated Show resolved Hide resolved
@Rei-x
Copy link
Member

Rei-x commented Sep 28, 2024

now it is sorted on the backend

@simon-the-shark
Copy link
Member

@mikolaj-jalocha i guess we can skip this PR now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-the-shark simon-the-shark Awaiting requested review from simon-the-shark

Assignees

@mikolaj-jalocha mikolaj-jalocha

Labels
bug Something isn't working enhancement New feature or request
Projects
ToPWR
Status: Done
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

feat/ sort links on about us team
3 participants
@mikolaj-jalocha @Rei-x @simon-the-shark