Skip to content

Commit

Permalink
fix(contact-icons): workaround textfield's new hint bug
Browse files Browse the repository at this point in the history
  • Loading branch information
simon-the-shark committed Aug 9, 2024
1 parent eab2e31 commit 9cc2a7e
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 23 deletions.
2 changes: 1 addition & 1 deletion lib/features/form/widgets/form_fields.dart
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class MyFormField extends StatelessWidget {
filled: true,
hoverColor: context.colorTheme.blueAzure.withOpacity(0.1),
prefixIcon: prefixIcon,
hintText: hintText,
// hintText: hintText, //TODO(simon-the-shark): reverse this when they fix the hint bug
counter: counterText == null
? null
: Row(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ class _SocialLinkSectionState extends State<SocialLinkSection> {
formControl: widget.model.urlControl,
widget.model.model,
context.localize.url_field,
hintText: context.localize.link_field_hint,
hintText:
// ignore: avoid_redundant_argument_values
null, // TODO(simon-the-shark): fix this when flutter fixes hint
suffixIcon: Padding(
padding: const EdgeInsets.only(right: 4),
child: IconButton(
Expand Down
42 changes: 21 additions & 21 deletions pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ packages:
dependency: transitive
description:
name: _fe_analyzer_shared
sha256: "5aaf60d96c4cd00fe7f21594b5ad6a1b699c80a27420f8a837f4d68473ef09e3"
sha256: f256b0c0ba6c7577c15e2e4e114755640a875e885099367bf6e012b19314c834
url: "https://pub.dev"
source: hosted
version: "68.0.0"
version: "72.0.0"
_flutterfire_internals:
dependency: transitive
description:
Expand All @@ -29,7 +29,7 @@ packages:
dependency: transitive
description: dart
source: sdk
version: "0.1.0"
version: "0.3.2"
adaptive_number:
dependency: transitive
description:
Expand All @@ -42,10 +42,10 @@ packages:
dependency: "direct overridden"
description:
name: analyzer
sha256: "21f1d3720fd1c70316399d5e2bccaebb415c434592d778cce8acb967b8578808"
sha256: b652861553cd3990d8ed361f7979dc6d7053a9ac8843fa73820ab68ce5410139
url: "https://pub.dev"
source: hosted
version: "6.5.0"
version: "6.7.0"
analyzer_plugin:
dependency: transitive
description:
Expand Down Expand Up @@ -1070,18 +1070,18 @@ packages:
dependency: transitive
description:
name: leak_tracker
sha256: "7f0df31977cb2c0b88585095d168e689669a2cc9b97c309665e3386f3e9d341a"
sha256: "3f87a60e8c63aecc975dda1ceedbc8f24de75f09e4856ea27daf8958f2f0ce05"
url: "https://pub.dev"
source: hosted
version: "10.0.4"
version: "10.0.5"
leak_tracker_flutter_testing:
dependency: transitive
description:
name: leak_tracker_flutter_testing
sha256: "06e98f569d004c1315b991ded39924b21af84cf14cc94791b8aea337d25b57f8"
sha256: "932549fb305594d82d7183ecd9fa93463e9914e1b67cacc34bc40906594a1806"
url: "https://pub.dev"
source: hosted
version: "3.0.3"
version: "3.0.5"
leak_tracker_testing:
dependency: transitive
description:
Expand Down Expand Up @@ -1118,10 +1118,10 @@ packages:
dependency: transitive
description:
name: macros
sha256: "12e8a9842b5a7390de7a781ec63d793527582398d16ea26c60fed58833c9ae79"
sha256: "0acaed5d6b7eab89f63350bccd82119e6c602df0f391260d0e32b5e23db79536"
url: "https://pub.dev"
source: hosted
version: "0.1.0-main.0"
version: "0.1.2-main.4"
matcher:
dependency: transitive
description:
Expand All @@ -1134,10 +1134,10 @@ packages:
dependency: transitive
description:
name: material_color_utilities
sha256: "0e0a020085b65b6083975e499759762399b4475f766c21668c4ecca34ea74e5a"
sha256: f7142bb1154231d7ea5f96bc7bde4bda2a0945d2806bb11670e30b850d56bdec
url: "https://pub.dev"
source: hosted
version: "0.8.0"
version: "0.11.1"
meta:
dependency: "direct overridden"
description:
Expand Down Expand Up @@ -1748,26 +1748,26 @@ packages:
dependency: transitive
description:
name: test
sha256: "7ee446762c2c50b3bd4ea96fe13ffac69919352bd3b4b17bac3f3465edc58073"
sha256: "7ee44229615f8f642b68120165ae4c2a75fe77ae2065b1e55ae4711f6cf0899e"
url: "https://pub.dev"
source: hosted
version: "1.25.2"
version: "1.25.7"
test_api:
dependency: transitive
description:
name: test_api
sha256: "9955ae474176f7ac8ee4e989dadfb411a58c30415bcfb648fa04b2b8a03afa7f"
sha256: "5b8a98dafc4d5c4c9c72d8b31ab2b23fc13422348d2997120294d3bac86b4ddb"
url: "https://pub.dev"
source: hosted
version: "0.7.0"
version: "0.7.2"
test_core:
dependency: transitive
description:
name: test_core
sha256: "2bc4b4ecddd75309300d8096f781c0e3280ca1ef85beda558d33fcbedc2eead4"
sha256: "55ea5a652e38a1dfb32943a7973f3681a60f872f8c3a05a14664ad54ef9c6696"
url: "https://pub.dev"
source: hosted
version: "0.6.0"
version: "0.6.4"
theme_tailor:
dependency: "direct dev"
description:
Expand Down Expand Up @@ -1964,10 +1964,10 @@ packages:
dependency: transitive
description:
name: vm_service
sha256: "3923c89304b715fb1eb6423f017651664a03bf5f4b29983627c4da791f74a4ec"
sha256: f652077d0bdf60abe4c1f6377448e8655008eef28f128bc023f7b5e8dfeb48fc
url: "https://pub.dev"
source: hosted
version: "14.2.1"
version: "14.2.4"
watcher:
dependency: transitive
description:
Expand Down

0 comments on commit 9cc2a7e

Please sign in to comment.