Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support-Map Tests for Rhino #13

Merged
merged 1 commit into from
Jan 14, 2014

Conversation

dhaber
Copy link

@dhaber dhaber commented Jan 14, 2014

This patch adds Support Map Tests to the rhino test suite. It makes the following changes:

  1. Add compiled version of source-map (version 0.1.31) because Rhino can't dynamically pull in dependencies
  2. Add source-map to the Rhino build with a Header/Footer that wraps source-map as a less-friendly dependency
  3. Add hooks in RhinoTest to support per-test bootstraping and validation
  4. Add a SourceMapRhinoTest that bootstraps SourceMap tests and then validates them after they run
  5. Update lib/less/rhino.js to properly handle (some) source-map options and add a new one (--source-map-output-map-file) that will output the source-map to a separate file (so we can validate our Rhino tests)
  6. Add a new testRhinoSourceMap and add it to the test list

Also makes some minor bug fixes:
A. Fix typo in the Gruntfile.js for the sourcemap-test
B. Update Gradle build to always build the less-rhino-.js before running the tests
C. Remove unused callback in less-test.js

This patch adds Support Map Tests to the rhino test suite.  It makes the
following changes:

1.  Fix typo in the Gruntfile.js for the sourcemap-test
2.  Update Gradle build to always build the less-rhino-<version>.js
before running the tests
3. Add a new testRhinoSourceMap and add it to the test list
4. Add a SourceMapRhinoTest that bootstraps SourceMap tests and then
validates them after they run
5. Add hooks in RhinoTest to support custom bootstraping and validation
6. Add compiled version of source-map (version 0.1.31) because Rhino
can't dynamically pull in dependencies
7. Add source-map to the Rhino build with a Header/Footer that wraps
source-map as a less-friendly dependency
8. Update lib/less/rhino.js to properly handle (some) source-map options
and add a new one (--source-map-output-map-file) that will output the
source-map to a separate file (so we can validate our Rhino tests)
9. Remove unused callback in less-test.js
@SomMeri
Copy link
Owner

SomMeri commented Jan 14, 2014

Thank you a lot.

SomMeri added a commit that referenced this pull request Jan 14, 2014
@SomMeri SomMeri merged commit 9dde852 into SomMeri:rhino Jan 14, 2014
@SomMeri
Copy link
Owner

SomMeri commented Jan 14, 2014

@dhaber One of your changes have been conflicting with recent changes in less.js. It is in test/index.js file . I used less.js version, so let me know if it was wrong. For convenience, link to current index.js file

Thank you again for all pull requests.

@dhaber
Copy link
Author

dhaber commented Jan 14, 2014

@SomMeri - np - Thank you! I've only tested against the pre=merge branch so we should re-run all tests against the latest and confirm that all of the tests still pass.

@SomMeri
Copy link
Owner

SomMeri commented Jan 14, 2014

@dhaber I tried and jshint complained a lot #15. I fixed rhino.js today and will continue tomorrow if I find the time.

If you will continue in the meantime, let me know so we do not work on the same thing. I would find something else to do in the meantime then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants