Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crayon bug and ui_bullet issue #130

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix crayon bug and ui_bullet issue #130

merged 1 commit into from
Sep 24, 2024

Conversation

scheidec
Copy link
Contributor

@scheidec
Fix crayon bug and ui_bullet issue
b0e4e75 
- removed crayon and usethis as
  dependencies in favor of cli
- fixed bug in R version 4.4.1 with ui_bullet
  internal calls within loadAdatsAsList() and
  write_adat()
- Fixes SomaLogic#129
@scheidec
Copy link
Contributor Author

The crayon package was superseded by the cli package, and it is now recommended to move to the analogous functions in cli.

This was a helpful resource in the conversion: https://usethis.r-lib.org/articles/ui-cli-conversion.html

With these changes, I was able to remove crayon fully as a dependency, along with usethis, as the internal .value() function was the only place it was used in the R/ folder.

wschwarzmann
wschwarzmann approved these changes Sep 20, 2024
View reviewed changes
Copy link

@wschwarzmann wschwarzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thank you for all your hard work on this.

@scheidec scheidec merged commit 331300d into SomaLogic:main Sep 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wschwarzmann wschwarzmann wschwarzmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui_bullet issue in loadAdatsAsList and write_adat
2 participants
@scheidec @wschwarzmann