Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FP S5860 (unused-named-groups): Consider accesses via the index syntax #3685

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Fix FP S5860 (unused-named-groups): Consider accesses via the index syntax #3685

merged 2 commits into from
Feb 7, 2023

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

Fixes #3683

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource changed the title Fix FP S5860: Consider accesses via the index syntax Fix FP S5860 (unused-named-groups): Consider accesses via the index syntax Feb 7, 2023
victor-diez-sonarsource
victor-diez-sonarsource suggested changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@victor-diez-sonarsource victor-diez-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for indices.groups['foo']? otherwise LGTM

@sonarsource-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit cb3db60 into master Feb 7, 2023
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource mentioned this pull request Feb 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victor-diez-sonarsource victor-diez-sonarsource victor-diez-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix FP S5860 (unused-named-groups): Consider accesses via the index syntax
2 participants
@yassin-kammoun-sonarsource @victor-diez-sonarsource