-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SONAR-18974 fix ApplicationNodes capital A typo #586
SONAR-18974 fix ApplicationNodes capital A typo #586
Conversation
88311ce
to
44bab2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is such a great PR! One of the best on the helm chart so far!
The local functional validation does not show any critical issue, plus the fixtures are already confirming the absence of regression 👏
I have a small comment on using the deepMerge function when it's not needed. Apart from that, how do we communicate the deprecation to users? Setting (DEPRECATED)
to all ApplicationNodes values and then replicate all the parameters is not option, but shall we spend some words on the README about it? Plus, shall we leverage Warnings?
I agree, warning is a good option, and I'll add a quick section in the readme. |
1cfd0f9
to
989f04a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge now! 🚀
I edited slightly the readme and warning message. Feel free to revise them if needed.
Please do not forget to acknowledge the issues on SQ!
5d260aa
to
777c76a
Compare
777c76a
to
c53f7a9
Compare
Quality Gate passedIssues Measures |
No description provided.