Modify S3649(Python): Fix logic error (#4598)

SonarSource · Jan 7, 2025 · dff46bd · dff46bd
1 parent aa70967
commit dff46bd
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/rules/S3649/python/how-to-fix-it/sqlalchemy.adoc b/rules/S3649/python/how-to-fix-it/sqlalchemy.adoc
@@ -27,7 +27,7 @@ import sqlalchemy
 @app.route('/example')
 def get_users():
     user = request.args["user"]
-    conn = sqlalchemy.create_engine(connection_string)
+    engine = sqlalchemy.create_engine(connection_string)
     conn = engine.connect()
 
     conn.execute("SELECT user FROM users WHERE user = '" + user + "'") # Noncompliant
@@ -43,7 +43,7 @@ import sqlalchemy
 @app.route('/example')
 def get_users():
     user = request.args["user"]
-    conn = sqlalchemy.create_engine(connection_string)
+    engine = sqlalchemy.create_engine(connection_string)
     metadata = sqlalchemy.MetaData(bind=conn, reflect=True)
     users = metadata.tables['users']
     conn = engine.connect()