Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S7154: Fastly API tokens should not be disclosed #4489

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@loris-s-sonarsource loris-s-sonarsource changed the title Create rule S7154 Create rule S7154: Fastly API tokens should not be disclosed Nov 12, 2024
@loris-s-sonarsource loris-s-sonarsource marked this pull request as ready for review November 12, 2024 16:40
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To use infrastructure_takeover.adoc you need to define a service_name variable.

rules/S7154/secrets/rule.adoc Show resolved Hide resolved
rules/S7154/secrets/rule.adoc Outdated Show resolved Hide resolved
Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com>
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loris-s-sonarsource loris-s-sonarsource merged commit 77c4627 into master Dec 17, 2024
11 of 12 checks passed
@loris-s-sonarsource loris-s-sonarsource deleted the rule/add-RSPEC-S7154 branch December 17, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants