Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify rule S3541: Deprecate the rule (CPP-5904) #4559

Merged
merged 3 commits into from
Dec 11, 2024
+4 −9
Merged

Modify rule S3541: Deprecate the rule (CPP-5904) #4559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa63b63
S3541: Deprecate the rule
loic-joly-sonarsource Dec 5, 2024
111c5fc
Add tag removal
loic-joly-sonarsource Dec 10, 2024
794f084
Remove tags
loic-joly-sonarsource Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/deprecation.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

== In the RSPEC

The rule status (`/status` in the metadata) should be set to `deprecated`.
The rule status (`/status` in the metadata) should be set to `deprecated`, and its tags should be removed. If the rule is in `SonarWay`, it should be removed from this profile.

Optionally, `/extra/replacementRules` can list the rules that replace this rule.

Expand Down
11 changes: 3 additions & 8 deletions rules/S3541/cfamily/metadata.json
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tags should also be removed

Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,12 @@
},
"attribute": "CLEAR"
},
"status": "ready",
"status": "deprecated",
"remediation": {
"func": "Constant\/Issue",
"constantCost": "2min"
},
"tags": [
"redundant",
"clumsy"
],
"tags": [],
"extra": {
"replacementRules": [

Expand All @@ -28,8 +25,6 @@
"ruleSpecification": "RSPEC-3541",
"sqKey": "S3541",
"scope": "Main",
"defaultQualityProfiles": [
"Sonar way"
],
"defaultQualityProfiles": [],
"quickfix": "unknown"
}
Loading