-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create rule S6258[terraform]: Add AWS ElasticSearch Domains #544
Merged
nils-werner-sonarsource
merged 4 commits into
rule/S6258-add-terraform
from
rule/S6258-add-terraform-esdomain
Nov 10, 2021
Merged
Create rule S6258[terraform]: Add AWS ElasticSearch Domains #544
nils-werner-sonarsource
merged 4 commits into
rule/S6258-add-terraform
from
rule/S6258-add-terraform-esdomain
Nov 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierre-loup-tristant-sonarsource
requested changes
Oct 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the # Sensitive
comment is not at the right place.
pierre-loup-tristant-sonarsource
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nils-werner-sonarsource
changed the base branch from
master
to
rule/S6258-add-terraform
November 10, 2021 09:15
nils-werner-sonarsource
deleted the
rule/S6258-add-terraform-esdomain
branch
November 10, 2021 09:16
nils-werner-sonarsource
added a commit
that referenced
this pull request
Nov 14, 2021
* Create rule S6258[terraform]: Add AWS ElasticSearch Domains * Fix log type confusion * fix "sensitive" location Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
nils-werner-sonarsource
added a commit
that referenced
this pull request
Nov 14, 2021
* Create rule S6258[terraform]: Add AWS ElasticSearch Domains * Fix log type confusion * fix "sensitive" location Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
irina-batinic-sonarsource
pushed a commit
that referenced
this pull request
Dec 5, 2022
* Create rule S6258[terraform]: Add AWS ElasticSearch Domains * Fix log type confusion * fix "sensitive" location Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation ticket: SONARIAC-247
This issue also covers Amazon Opensearch Service on Terraform, which doesn't have its own terraform resource bloc but can be used with the
aws_elasticsearch_domain
bloc. This topic is discussed in this issue: hashicorp/terraform-provider-aws#20853