Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S6258[terraform]: Add AWS ElasticSearch Domains #544

Conversation

loris-s-sonarsource
Copy link
Contributor

@loris-s-sonarsource loris-s-sonarsource commented Oct 26, 2021

Implementation ticket: SONARIAC-247


This issue also covers Amazon Opensearch Service on Terraform, which doesn't have its own terraform resource bloc but can be used with the aws_elasticsearch_domain bloc. This topic is discussed in this issue: hashicorp/terraform-provider-aws#20853

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the # Sensitive comment is not at the right place.

rules/S6258/terraform/rule.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nils-werner-sonarsource nils-werner-sonarsource changed the base branch from master to rule/S6258-add-terraform November 10, 2021 09:15
@nils-werner-sonarsource nils-werner-sonarsource merged commit 5810d42 into rule/S6258-add-terraform Nov 10, 2021
@nils-werner-sonarsource nils-werner-sonarsource deleted the rule/S6258-add-terraform-esdomain branch November 10, 2021 09:16
nils-werner-sonarsource added a commit that referenced this pull request Nov 14, 2021
* Create rule S6258[terraform]: Add AWS ElasticSearch Domains

* Fix log type confusion

* fix "sensitive" location

Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
nils-werner-sonarsource added a commit that referenced this pull request Nov 14, 2021
* Create rule S6258[terraform]: Add AWS ElasticSearch Domains

* Fix log type confusion

* fix "sensitive" location

Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
irina-batinic-sonarsource pushed a commit that referenced this pull request Dec 5, 2022
* Create rule S6258[terraform]: Add AWS ElasticSearch Domains

* Fix log type confusion

* fix "sensitive" location

Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants