SONARXML-146 Allow checks to access SensorContext to read configuration #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardo-pilastri-sonarsource
force-pushed
the
lp/SONARXML-146
branch
from
006bdbc to
919c474
Compare
dorian-burihabwa-sonarsource
approved these changes
Oct 4, 2024
leonardo-pilastri-sonarsource
force-pushed
the
lp/SONARXML-146
branch
2 times, most recently
from
84fb1ca to
731d697
Compare
leonardo-pilastri-sonarsource
force-pushed
the
lp/SONARXML-146
branch
from
731d697 to
fac11be
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of implementing XMLChecks that rely on analysis properties, like "sonar.android.minsdkversion.min", which are gathered by the scanners and stored into the
SensorContext.config(), this PR wants to allow SonarXMLCheck implementations to access the context, and allow the SonarXMLCheckVerifier to pass this kind of configuration to properly test the expected behavior of such checks.