UtilityAnalyzer: Wrong classifications: ref types (#7824)

SonarSource · Aug 18, 2023 · 360a2a5 · 360a2a5
1 parent 18f120f
commit 360a2a5
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/analyzers/src/SonarAnalyzer.CSharp/Rules/Utilities/TokenTypeAnalyzer.cs b/analyzers/src/SonarAnalyzer.CSharp/Rules/Utilities/TokenTypeAnalyzer.cs
@@ -318,6 +318,7 @@ private static bool IsInTypeContext(SimpleNameSyntax name) =>
  { RawKind: (int)SyntaxKind.ParenthesizedLambdaExpression } x => ((ParenthesizedLambdaExpressionSyntaxWrapper)x).ReturnType == name,
  { RawKind: (int)SyntaxKindEx.FileScopedNamespaceDeclaration } x => ((FileScopedNamespaceDeclarationSyntaxWrapper)x).Name == name,
  { RawKind: (int)SyntaxKindEx.TupleElement } x => ((TupleElementSyntaxWrapper)x).Type == name,
+ { RawKind: (int)SyntaxKindEx.RefType } x => ((RefTypeSyntaxWrapper)x).Type == name,
  _ => false,
  };
  }

diff --git a/analyzers/tests/SonarAnalyzer.UnitTest/Rules/Utilities/TokenTypeAnalyzerTest.Classifier.cs b/analyzers/tests/SonarAnalyzer.UnitTest/Rules/Utilities/TokenTypeAnalyzerTest.Classifier.cs
@@ -635,6 +635,27 @@ public void M()
  }
  """, allowSemanticModel, ignoreCompilationErrors);
 
+ [DataTestMethod]
+ [DataRow("[t:Int32]", false)]
+ [DataRow("[t:Int32]?", false)]
+ [DataRow("System.[t:Int32]", false)]
+ [DataRow("System.Nullable<[t:Int32]>", false)]
+ [DataRow("[t:T]", false)]
+ public void IdentifierToken_Type_Ref(string refTypeName, bool allowSemanticModel = true) =>
+ ClassifierTestHarness.AssertTokenTypes($$"""
+ using System;
+
+ public class Test<T>
+ {
+ {{refTypeName}} item;
+ 
+ public ref {{refTypeName}} M()
+ {
+ return ref item;
+ }
+ }
+ """, allowSemanticModel);
+
 #endif
 
  [DataTestMethod]