TokenType: Tests and support for scoped type declarations #8061
Conversation
| [DataRow("scoped ref [t:S] s", false)] | ||
| [DataRow("ref [t:S] s", false)] | ||
| [DataRow("scoped [t:S] s", false)] | ||
| public void IdentifierToken_Scoped_Parameter(string parameterDeclaration, bool allowSemanticModel) => |
There was a problem hiding this comment.
Optional: We could add a test combining scoped ref with readonly, when the reference is one to a readonly ref struct, just to make sure that readonly is interpreted as keyword, when following ref.
E.g. here, where GitHub fails at properly coloring it.
There was a problem hiding this comment.
This does not compile (readonly parameter are at implemented proposal stage dotnet/csharplang#6010 for C#12). But for locals it works and I added a test case.
| { | ||
| } | ||
| } | ||
| """, allowSemanticModel); |
There was a problem hiding this comment.
Optional: I would also add tests with a parameter and/or variable named scope. Unlike other keyword, that require escaping with @, scope has been introduced recently, and as such, is not tokenized as a keyword when used after the type:
int scoped = 3;I think it would make sense to assert that scoped is of type u, and not k.
martin-strecker-sonarsource
force-pushed
the
Martin/TokenType_Scoped
branch
from
8834896 to
fec1567
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Follow up to #7369