Fix quality flaw: Move invariant to the correct place.

SonarSource · Feb 1, 2017 · f5a869c · f5a869c
1 parent 8c313a7
commit f5a869c
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/java-frontend/src/main/java/org/sonar/java/se/checks/NullDereferenceCheck.java b/java-frontend/src/main/java/org/sonar/java/se/checks/NullDereferenceCheck.java
@@ -125,8 +125,8 @@ public ProgramState checkPostStatement(CheckerContext context, Tree syntaxNode)
 
   private static List<ProgramState> setNullConstraint(CheckerContext context, Tree syntaxNode) {
     SymbolicValue val = context.getState().peekValue();
-    Preconditions.checkNotNull(val);
     if (syntaxNode.is(Tree.Kind.METHOD_INVOCATION) && isAnnotatedCheckForNull((MethodInvocationTree) syntaxNode)) {
+      Preconditions.checkNotNull(val);
       List<ProgramState> states = new ArrayList<>();
       states.addAll(val.setConstraint(context.getState(), ObjectConstraint.nullConstraint()));
       states.addAll(val.setConstraint(context.getState(), ObjectConstraint.notNull()));