Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARJAVA-4606 New rule: use String.isEmpty() instead of String.length() == 0 #4925

Merged
merged 4 commits into from
Nov 21, 2024
Merged

SONARJAVA-4606 New rule: use String.isEmpty() instead of String.length() == 0 #4925

merged 4 commits into from
Nov 21, 2024

Conversation

tomasz-tylenda-sonarsource
Copy link
Contributor

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource commented Nov 12, 2024 •
edited by jira bot
Loading

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource changed the title SONARJAVA-4606 New rule: use String.isEmpty() instead of String.length() == 0 SONARJAVA-5181 New rule: use String.isEmpty() instead of String.length() == 0 Nov 14, 2024
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource force-pushed the tt/rule-isEmpty branch 2 times, most recently from bd2bfaf to 824ae73 Compare November 19, 2024 08:26
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource changed the title SONARJAVA-5181 New rule: use String.isEmpty() instead of String.length() == 0 SONARJAVA-4606 New rule: use String.isEmpty() instead of String.length() == 0 Nov 19, 2024
leonardo-pilastri-sonarsource
leonardo-pilastri-sonarsource requested changes Nov 19, 2024
View reviewed changes
java-checks/src/test/java/org/sonar/java/checks/StringIsEmptyCheckTest.java Show resolved Hide resolved
java-checks/src/main/java/org/sonar/java/checks/StringIsEmptyCheck.java Outdated Show resolved Hide resolved
java-checks/src/main/java/org/sonar/java/checks/StringIsEmptyCheck.java Outdated Show resolved Hide resolved
java-checks/src/main/java/org/sonar/java/checks/StringIsEmptyCheck.java Outdated Show resolved Hide resolved
java-checks/src/main/java/org/sonar/java/checks/StringIsEmptyCheck.java Outdated Show resolved Hide resolved
java-checks/src/main/java/org/sonar/java/checks/StringIsEmptyCheck.java Outdated Show resolved Hide resolved
java-checks/src/main/java/org/sonar/java/checks/StringIsEmptyCheck.java Outdated Show resolved Hide resolved
java-checks/src/main/java/org/sonar/java/checks/StringIsEmptyCheck.java Outdated Show resolved Hide resolved
java-checks/src/main/java/org/sonar/java/checks/StringIsEmptyCheck.java Outdated Show resolved Hide resolved
leonardo-pilastri-sonarsource
leonardo-pilastri-sonarsource approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
96.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@leonardo-pilastri-sonarsource leonardo-pilastri-sonarsource merged commit 8994f83 into master Nov 21, 2024
17 checks passed
@leonardo-pilastri-sonarsource leonardo-pilastri-sonarsource deleted the tt/rule-isEmpty branch November 21, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardo-pilastri-sonarsource leonardo-pilastri-sonarsource Awaiting requested review from leonardo-pilastri-sonarsource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomasz-tylenda-sonarsource @leonardo-pilastri-sonarsource @alban-auzeill