PLUGINAPI-122 Standard severities need to be mapped to all the five i…

…mpact severities
SonarSource · Feb 27, 2025 · 2868298 · 2868298
1 parent dc2df61
commit 2868298
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,7 @@
 # Changelog
+## 11.2
+* Standard Severity BLOCKER is now mapped to Software Quality Impact Severity BLOCKER
+* Standard Severity INFO is now mapped to Software Quality Impact Severity INFO
 
 ## 11.1
 * Remove deprecation on `status` values `TO_REVIEW`, `REVIEWED` and related usages

diff --git a/plugin-api/src/main/java/org/sonar/api/server/rule/internal/ImpactMapper.java b/plugin-api/src/main/java/org/sonar/api/server/rule/internal/ImpactMapper.java
@@ -97,13 +97,15 @@ public static String convertToDeprecatedSeverity(Severity severity) {
   public static Severity convertToImpactSeverity(String ruleSeverity) {
     switch (ruleSeverity) {
       case BLOCKER:
+        return Severity.BLOCKER;
       case CRITICAL:
         return Severity.HIGH;
       case MAJOR:
         return Severity.MEDIUM;
       case MINOR:
-      case INFO:
         return Severity.LOW;
+      case INFO:
+        return Severity.INFO;
       default:
         throw new IllegalStateException("This severity value " + ruleSeverity + " is illegal.");
     }

diff --git a/plugin-api/src/test/java/org/sonar/api/server/rule/internal/ImpactMapperTest.java b/plugin-api/src/test/java/org/sonar/api/server/rule/internal/ImpactMapperTest.java
@@ -152,17 +152,17 @@ public void convertToSeverity_givenMinor_returnLow() {
   }
 
   @Test
-  public void convertToSeverity_givenInfo_returnLow() {
+  public void convertToSeverity_givenInfo_returnInfo() {
     Severity severity = ImpactMapper.convertToImpactSeverity("INFO");
 
-    assertThat(severity).isEqualTo(LOW);
+    assertThat(severity).isEqualTo(INFO);
   }
 
   @Test
-  public void convertToSeverity_givenBlocker_returnHigh() {
+  public void convertToSeverity_givenBlocker_returnBlock() {
     Severity severity = ImpactMapper.convertToImpactSeverity("BLOCKER");
 
-    assertThat(severity).isEqualTo(HIGH);
+    assertThat(severity).isEqualTo(BLOCKER);
   }
 
   @Test