SONARPY-2290 Support decorators for FunctionType to descriptors converter #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksim-grebeniuk-sonarsource
force-pushed
the
SONARPY-2290
branch
from
1d0a237
to
91fb255
Compare
guillaume-dequenne-sonarsource
force-pushed
the
MMF-3945
branch
from
759e9d2
to
a5e22df
Compare
maksim-grebeniuk-sonarsource
force-pushed
the
SONARPY-2290
branch
3 times, most recently
from
44d3051
to
a1f9d45
Compare
maksim-grebeniuk-sonarsource
force-pushed
the
SONARPY-2290
branch
from
a1f9d45
to
c99a4e4
Compare
maksim-grebeniuk-sonarsource
requested a review
from guillaume-dequenne-sonarsource
guillaume-dequenne-sonarsource
requested changes
Nov 5, 2024
Comment on lines
+46
to
47
| "abc.abstractmethod", | ||
| "abstractmethod", |
There was a problem hiding this comment.
Can you add (either in ProjectLevelTypeTableTest or ProjectLevelSymbolTableTest, or any relevant place) a test that highlights the discrepancies between decorator properly resolved from Typeshed (where I assume we only get a local name) and the case where a proper FQN is resolved?
We should also have a ticket to track this.
maksim-grebeniuk-sonarsource
requested a review
from guillaume-dequenne-sonarsource
|
guillaume-dequenne-sonarsource
approved these changes
Nov 5, 2024
guillaume-dequenne-sonarsource
merged commit 20f960f
into
MMF-3945
7 of 11 checks passed
maksim-grebeniuk-sonarsource
added a commit
that referenced
this pull request
Nov 5, 2024
guillaume-dequenne-sonarsource
pushed a commit
that referenced
this pull request
Nov 6, 2024
guillaume-dequenne-sonarsource
pushed a commit
that referenced
this pull request
Nov 6, 2024
guillaume-dequenne-sonarsource
pushed a commit
that referenced
this pull request
Nov 6, 2024
guillaume-dequenne-sonarsource
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARPY-2290