Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA Update development scripts & documentation #254

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

7PH
Copy link
Member

@7PH 7PH commented Jun 6, 2023

  • Please explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
  • Use the following formatting style: SonarSource/sonar-developer-toolset
  • Provide a unit test for any code you changed
  • If there is a JIRA ticket available, please make your commits and pull request start with the ticket ID (VSTS-XXXX)

Summary

The developer guide was not working as expected when setting up a dev environment. Here are the changes:

  • Minimum node requirement for development bumped to v14 from v6. Rationale:
  • I felt free to update package-lock.json which is un-synced from package.json (eg running a cleaninstall on root folder was giving cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with npm install before continuing
  • Updated gulpfile to not expect cyclonedx to be present in the global PATH and instead use the binary from node

@7PH 7PH added enhancement dependencies Pull requests that update a dependency file labels Jun 6, 2023
@7PH 7PH self-assigned this Jun 6, 2023
@7PH 7PH force-pushed the task/br/no-jira-update-developer-scripts-and-doc branch from cbdc65a to 29f00b5 Compare June 6, 2023 09:52
@7PH 7PH force-pushed the task/br/no-jira-update-developer-scripts-and-doc branch from 29f00b5 to 88340df Compare June 6, 2023 09:53
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
gulpfile.js Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
Copy link
Contributor

@mickael-caro-sonarsource mickael-caro-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@7PH 7PH changed the base branch from master to sprint-1 June 6, 2023 15:18
@7PH 7PH merged commit 325e80f into sprint-1 Jun 6, 2023
@7PH 7PH deleted the task/br/no-jira-update-developer-scripts-and-doc branch June 6, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants