SCAN4NET-171 Read new properties for downloading plugins #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
alex-meseldzija-sonarsource
force-pushed
the
alex/SCAN4NET-171
branch
2 times, most recently
from
0e8ecff to
fdc4cef
Compare
pavel-mikula-sonarsource
requested changes
Jan 24, 2025
src/SonarScanner.MSBuild.PreProcessor/Interfaces/IAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
src/SonarScanner.MSBuild.PreProcessor/Roslyn/RoslynAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
src/SonarScanner.MSBuild.PreProcessor/Roslyn/RoslynAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
src/SonarScanner.MSBuild.PreProcessor/Roslyn/RoslynAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
src/SonarScanner.MSBuild.PreProcessor/Roslyn/RoslynAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
src/SonarScanner.MSBuild.PreProcessor/Roslyn/RoslynAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
src/SonarScanner.MSBuild.PreProcessor/Roslyn/RoslynAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
alex-meseldzija-sonarsource
force-pushed
the
alex/SCAN4NET-171
branch
2 times, most recently
from
51fadff to
ad8f09f
Compare
alex-meseldzija-sonarsource
changed the base branch from
master
to
alex/refactor-fetch-analyzer-plugin
alex-meseldzija-sonarsource
force-pushed
the
alex/refactor-fetch-analyzer-plugin
branch
2 times, most recently
from
5fb0eda to
1e11364
Compare
alex-meseldzija-sonarsource
force-pushed
the
alex/SCAN4NET-171
branch
from
ad8f09f to
ac9dd05
Compare
alex-meseldzija-sonarsource
force-pushed
the
alex/refactor-fetch-analyzer-plugin
branch
from
1e11364 to
f4efaca
Compare
alex-meseldzija-sonarsource
force-pushed
the
alex/SCAN4NET-171
branch
2 times, most recently
from
98affdf to
f089335
Compare
Base automatically changed from
alex/refactor-fetch-analyzer-plugin
to
master
January 31, 2025 15:20
alex-meseldzija-sonarsource
force-pushed
the
alex/SCAN4NET-171
branch
from
f089335 to
80132ec
Compare
pavel-mikula-sonarsource
requested changes
Feb 3, 2025
Tests/SonarScanner.MSBuild.PreProcessor.Test/Infrastructure/MockAnalyzerInstaller.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/Infrastructure/MockAnalyzerInstaller.cs
Outdated
Show resolved
Hide resolved
src/SonarScanner.MSBuild.PreProcessor/Roslyn/RoslynAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
src/SonarScanner.MSBuild.PreProcessor/Roslyn/RoslynAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/RoslynAnalyzerProviderTests.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/RoslynAnalyzerProviderTests.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/RoslynAnalyzerProviderTests.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/RoslynAnalyzerProviderTests.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/RoslynAnalyzerProviderTests.cs
Outdated
Show resolved
Hide resolved
alex-meseldzija-sonarsource
force-pushed
the
alex/SCAN4NET-171
branch
from
74cc6da to
05ea7ee
Compare
|
pavel-mikula-sonarsource
requested changes
Feb 4, 2025
| {"sonaranalyzer.security.cs.staticResourceName", "OLDSecurityCSharpFrontend" }, | ||
| }); | ||
| var context = new Context(TestContext, sonarProperties, [[@"c:\assembly1.dll"], [@"d:\foo\assembly2.dll"]], null, language); | ||
| var securityProperties = language == RoslynAnalyzerProvider.CSharpLanguage ? |
There was a problem hiding this comment.
securityProperties and expectedSonarLintXml are the same for RoslynConfig_ValidProfile_WithLegacy and RoslynConfig_ValidProfile_WithoutLegacy.
Extract it. And use the same scaffolding (add security) also in RoslynConfig_ValidProfile_LegacyOnly. Then it will be used 3x.
Comment on lines
+187
to
+195
| var expectedPlugins = new List<Plugin>() | ||
| { | ||
| new() { Key = "wintellect", Version = "1.13.0", StaticResourceName = "wintellect.zip" }, | ||
| new() { Key = language, Version = "1.42.0", StaticResourceName = "SonarAnalyzer.zip" }, | ||
| }; | ||
| if (language == RoslynAnalyzerProvider.CSharpLanguage) | ||
| { | ||
| expectedPlugins.Add(new() { Key = "securitycsharpfrontend", Version = "1.42.0", StaticResourceName = "SecurityAnalyzer.zip" }); | ||
| } |
There was a problem hiding this comment.
Calculation of expectedPlugins should be also extracted, as it will be used 3x
pavel-mikula-sonarsource
approved these changes
Feb 4, 2025
Comment on lines
+142
to
+153
| <Setting> | ||
| <Key>sonar.{language}.analyzer.dotnet.pluginKey</Key> | ||
| <Value>{language}</Value> | ||
| </Setting> | ||
| <Setting> | ||
| <Key>sonar.{language}.analyzer.dotnet.pluginVersion</Key> | ||
| <Value>1.42.0</Value> | ||
| </Setting> | ||
| <Setting> | ||
| <Key>sonar.{language}.analyzer.dotnet.staticResourceName</Key> | ||
| <Value>SonarAnalyzer.zip</Value> | ||
| </Setting> |
There was a problem hiding this comment.
Oversight from previous review: We shouldn't generate these to SonarLint.xml file, as sonaranalyzer-{language} where previously also not generated.
We use them to talk to scanner. We should not propagate them back to the analyzers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCAN4NET-171