SCANNPM-42 Allow scan to run without a token provided (#161)

SonarSource · Aug 14, 2024 · 182af86 · 182af86
1 parent a7143c2
commit 182af86
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "sonarqube-scanner",
   "description": "SonarQube/SonarCloud Scanner for the JavaScript world",
-  "version": "4.2.0",
+  "version": "4.2.1",
   "homepage": "https://github.com/SonarSource/sonar-scanner-npm",
   "author": {
     "name": "Fabrice Bellingard",

diff --git a/src/request.ts b/src/request.ts
@@ -116,9 +116,7 @@ export async function initializeAxios(properties: ScannerProperties) {
     _axiosInstances = {
       internal: axios.create({
         baseURL,
-        headers: {
-          Authorization: `Bearer ${token}`,
-        },
+        headers: token ? { Authorization: `Bearer ${token}` } : {},
         timeout,
         ...agents,
       }),

diff --git a/test/unit/request.test.ts b/test/unit/request.test.ts
@@ -208,6 +208,24 @@ describe('request', () => {
         timeout: 23000,
       });
     });
+
+    it('should initialize axios without token', async () => {
+      jest.spyOn(axios, 'create');
+
+      await initializeAxios({
+        [ScannerProperty.SonarHostUrl]: SONARCLOUD_URL,
+        [ScannerProperty.SonarScannerApiBaseUrl]: SONARCLOUD_API_BASE_URL,
+      });
+
+      expect(axios.create).toHaveBeenCalledWith({
+        baseURL: SONARCLOUD_API_BASE_URL,
+        headers: {},
+        timeout: 0,
+      });
+      expect(axios.create).toHaveBeenCalledWith({
+        timeout: 0,
+      });
+    });
   });
 
   describe('fetch', () => {