forked from bellingard/sonar-scanner-npm
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCANNPM-2 Use axios instance to re-use fetching logic #120
Merged
lucas-paulger-sonarsource
merged 1 commit into
feature/MMF-3712
from
feature/br/scannpm-18-use-axios-instance-to-re-use-fetching-logic
Apr 23, 2024
Merged
SCANNPM-2 Use axios instance to re-use fetching logic #120
lucas-paulger-sonarsource
merged 1 commit into
feature/MMF-3712
from
feature/br/scannpm-18-use-axios-instance-to-re-use-fetching-logic
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7PH
changed the title
SCANNPM-2 Refactor fetch(..) to take properties object rather than token
SCANNPM-2 Use axios instance to re-use fetching logic
Apr 22, 2024
7PH
force-pushed
the
feature/br/scannpm-18-use-axios-instance-to-re-use-fetching-logic
branch
3 times, most recently
from
April 22, 2024 14:19
fc99718
to
abe0633
Compare
7PH
commented
Apr 22, 2024
7PH
force-pushed
the
feature/br/scannpm-18-use-axios-instance-to-re-use-fetching-logic
branch
3 times, most recently
from
April 22, 2024 15:22
7882e09
to
29b035f
Compare
7PH
force-pushed
the
feature/br/scannpm-18-use-axios-instance-to-re-use-fetching-logic
branch
from
April 22, 2024 15:27
29b035f
to
b89ad27
Compare
I would push to merge this first so we can address it in the respective PRs now. wdyt? |
7PH
force-pushed
the
feature/br/scannpm-18-use-axios-instance-to-re-use-fetching-logic
branch
from
April 23, 2024 07:21
b89ad27
to
3338e1e
Compare
lucas-paulger-sonarsource
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beautiful 💯
lucas-paulger-sonarsource
merged commit Apr 23, 2024
6bad249
into
feature/MMF-3712
0 of 4 checks passed
lucas-paulger-sonarsource
deleted the
feature/br/scannpm-18-use-axios-instance-to-re-use-fetching-logic
branch
April 23, 2024 11:13
7PH
added a commit
that referenced
this pull request
May 3, 2024
7PH
added a commit
that referenced
this pull request
May 3, 2024
lucas-paulger-sonarsource
pushed a commit
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initializeAxios(properties)
was added to the top ofscan.ts
http-agent.ts
code torequest.ts
params: { .. }
to pass GET params to urls