Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable shell on Windows #131

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Enable shell on Windows #131

merged 5 commits into from
Apr 26, 2024

Conversation

vdiez
Copy link

@vdiez vdiez commented Apr 26, 2024

Fixes #113

nothing from the env is being passed as arguments in the cmd, so we should be safe. Only cli args will be forwarded

Co-authored-by: Ilia Kebets <104737176+ilia-kebets-sonarsource@users.noreply.github.com>
@ilia-kebets-sonarsource

Could you write up the rationale for this decision in the PR?

Copy link

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Apr 26, 2024

@vdiez vdiez merged commit 3779734 into master Apr 26, 2024
6 checks passed
@vdiez vdiez deleted the fix-shell branch April 26, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SonarScanner fails when executing in a Windows environment
2 participants