Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCANNPM-38 Fully support sonar-project.properties file parsing #149

Conversation

7PH
Copy link
Member

@7PH 7PH commented Jun 23, 2024

ticket

Add a properties-file dependency to parse properties file format

The divergence I found compared to the spec is backslashes. The spec says

# If you want your value to include a backslash ('\'), it should be escaped by another backslash ('\').
path = c:\\wiki\\templates

but when testing, the path comes down to c:\\wiki\\templates instead of c:\wiki\templates. But it was the same with other libraries I've tested (please see tickets).

@7PH 7PH force-pushed the feature/br/scannpm-38-support-newlines-in-sonar-project-properties-file branch 2 times, most recently from e00727a to c4aa340 Compare June 23, 2024 22:39
@7PH 7PH changed the title SCANNPM-38 Fully support sonar-project.properties SCANNPM-38 Fully support sonar-project.properties file parsing Jun 23, 2024
@7PH 7PH force-pushed the feature/br/scannpm-38-support-newlines-in-sonar-project-properties-file branch 2 times, most recently from 22a4660 to 3a4a220 Compare June 23, 2024 22:48
@7PH 7PH requested a review from vdiez June 24, 2024 07:14
@7PH 7PH force-pushed the feature/br/scannpm-38-support-newlines-in-sonar-project-properties-file branch 2 times, most recently from 0c56380 to 5d5b16d Compare June 24, 2024 08:14
Copy link

@vdiez vdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Always good to simplify the codebase like this

@7PH 7PH force-pushed the feature/br/scannpm-38-support-newlines-in-sonar-project-properties-file branch from 5d5b16d to 695c862 Compare June 24, 2024 13:10
Copy link

@7PH 7PH merged commit ee24fc8 into master Jun 24, 2024
6 checks passed
@7PH 7PH deleted the feature/br/scannpm-38-support-newlines-in-sonar-project-properties-file branch June 24, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants