Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCANNPM-52 Fix scanner archive directory when having an architecture #174

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

henryju
Copy link
Member

@henryju henryju commented Oct 14, 2024

No description provided.

@henryju henryju requested a review from 7PH October 14, 2024 14:04
package-lock.json Outdated Show resolved Hide resolved
@henryju henryju force-pushed the jh/fix_folder_name branch from 2db974b to af9900f Compare October 14, 2024 14:32
@henryju henryju requested a review from 7PH October 14, 2024 14:32
Copy link
Member

@7PH 7PH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, validated with SQ 10.8-snapshot, 9.9 with default Scanner CLI and Scanner CLI 6.0.0.4432

src/scanner-cli.ts Outdated Show resolved Hide resolved
@7PH 7PH force-pushed the jh/fix_folder_name branch 2 times, most recently from 52a70e7 to 5ad68a6 Compare October 14, 2024 14:54
Co-authored-by: Benjamin Raymond <31401273+7PH@users.noreply.github.com>
@7PH 7PH force-pushed the jh/fix_folder_name branch from 5ad68a6 to d962e35 Compare October 14, 2024 14:57
Copy link

@7PH 7PH merged commit 17716e8 into master Oct 14, 2024
6 checks passed
@7PH 7PH deleted the jh/fix_folder_name branch October 14, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants