Set up locale env variables #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dagwieers @kenhuang @simonbrandhof (sorry for pointing directly at you, I've just picked last 3 contributors) are there any chances in merging this PR? |
tom-vanbraband-sonarsource
requested changes
Jan 29, 2021
There was a problem hiding this comment.
Apologies for the delay.
Can you explain why setting just ENV LC_ALL="C.UTF-8" is not enough? According to the documentation this variable takes precedence over all others.
Dockerfile
Outdated
| @@ -14,6 +14,12 @@ ARG NODEJS_HOME=/opt/nodejs | |||
|
|
|||
| ENV PATH=${PATH}:${SONAR_SCANNER_HOME}/bin:${NODEJS_HOME}/bin | |||
|
|
|||
| # set up local envs in order to allow for special chars (non-asci) in filenames | |||
| ENV LC_TYPE="C.UTF-8" | |||
There was a problem hiding this comment.
I believe the correct key is LC_CTYPE
Suggested change
| ENV LC_TYPE="C.UTF-8" | |
| ENV LC_CTYPE="C.UTF-8" |
There was a problem hiding this comment.
@tom-vanbraband-sonarsource sorry for the delay. Yep - you are right LC_ALL is enough. I've adjusted the PR content.
lukaszzdanikowski
force-pushed
the
patch-1
branch
from
de27e24 to
0b086ab
Compare
Setting those variables fixes the issue that sonar has with non-asci chars in filenames
lukaszzdanikowski
force-pushed
the
patch-1
branch
from
0b086ab to
cf7128a
Compare
konrad-nowacki
approved these changes
Feb 19, 2021
|
Hi @tom-vanbraband-sonarsource any updates on the PR? |
jkowalleck
approved these changes
Mar 13, 2021
tom-vanbraband-sonarsource
approved these changes
Apr 19, 2021
|
Thanks @lukaszzdanikowski! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting those variables fixes the issue that sonar has with non-asci chars in filenames