Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPP-5241 Migrate github action from build-wrapper-output to compilation-database #54

Merged
merged 1 commit into from
May 21, 2024

Conversation

friedbyalice
Copy link
Contributor

List of checkpoint to verify/do before merging a PR.

Dev checklist

  • Write/update tests
  • Functional validation
  • Public documentation update
  • Private documentation update
  • Clean commits (should start with a ticket number, clear message, no fixup, wip)
  • Maximize code coverage as much as possible

Reviewer checklist

  • Code review
  • Functional validation
  • Check commits are clean

Steps to validate this PR

Fill-in how you performed the validation, and how the reviewer can replicate it:

  • [ ]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side. Could you also amend the commit to include the ticket number?

I think that we can merge this PR now as the new version of the analyzer is now live on SC.

Copy link

@antoine-vinot-sonarsource antoine-vinot-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The PR is still in a Draft state. We usually mark it as ready for review before assigning reviewers.

@michael-jabbour-sonarsource michael-jabbour-sonarsource marked this pull request as ready for review May 21, 2024 08:45
@michael-jabbour-sonarsource
Copy link
Contributor

Thanks for pointing that out @antoine-vinot-sonarsource. Do you think we can go ahead and proceed with the merge now?

@antoine-vinot-sonarsource

Thanks for pointing that out @antoine-vinot-sonarsource. Do you think we can go ahead and proceed with the merge now?

Yes sure, I approved it already.

@michael-jabbour-sonarsource michael-jabbour-sonarsource merged commit 5c3c391 into main May 21, 2024
10 checks passed
@michael-jabbour-sonarsource michael-jabbour-sonarsource deleted the vp/bwUsesCd branch May 21, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants