SLLS-277 Fix JsonNull conversion error #410
Merged
+70
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some LSP clients do not send values outside of of configuration
namespace. For example Neovim does not support sending client
configurations to mimic the VScode behavior. Following in Lua is not
possible.
```lua
require('sonarlint').setup({
server = {
cmd = {
-- …
},
settings = {
sonarlint = {
-- …
},
["files.exclude"] = { ["**/.git"] = true },
}
},
})
```
This commit makes sure that sonarlint language server still functions if
the values won't be sent. Otherwise, the language server errors while
loading the project.
hashicorp-vault-sonar-prod
bot
changed the title
jblievremont
force-pushed
the
contrib/schrieveslaach-sonarlint-language-server
branch
3 times, most recently
from
5b622c0 to
19912c4
Compare
jblievremont
force-pushed
the
contrib/schrieveslaach-sonarlint-language-server
branch
from
19912c4 to
6eab87d
Compare
|
nquinquenel
approved these changes
Nov 14, 2024
|
|
||
| @Override | ||
| public String[] getVersion() throws Exception { | ||
| try(var versionStream = getClass().getResourceAsStream("/slls-version.txt")) { |
There was a problem hiding this comment.
Suggested change
| try(var versionStream = getClass().getResourceAsStream("/slls-version.txt")) { | |
| try (var versionStream = getClass().getResourceAsStream("/slls-version.txt")) { |
| @@ -98,4 +101,14 @@ public static void main(String... args) { | |||
| System.exit(exitCode); | |||
| } | |||
|
|
|||
| public static class MavenVersionProvider implements IVersionProvider { | |||
There was a problem hiding this comment.
How is it related to Maven?
There was a problem hiding this comment.
My original version in #402 provided that name because it was taken from the Maven attributes in JAR's manifest. Probably, renaming is a good idea.
Suggested change
| public static class MavenVersionProvider implements IVersionProvider { | |
| public static class SonarlintVersionProvider implements IVersionProvider { |
There was a problem hiding this comment.
It is related to Maven because slls-version.txt is a Maven-filtered resource that contains the ${project.version} property.
I believe it is slightly more robust than the initial implementation because:
- This file is provided only by the language server build itself - it is not automagically generated by some Maven plugin or copied from a random JAR when building the über-JAR with dependencies
- It contains exactly the property that we want to show with the
--versionoption
jblievremont
deleted the
contrib/schrieveslaach-sonarlint-language-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLLS-277
Internal copy of #402 to let CI checks run