Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQCPPGHA-5 Support Running on Linux ARM64 with generic CLI Scanner #11

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

friedbyalice
Copy link
Contributor

@friedbyalice friedbyalice commented Jun 24, 2024

No description provided.

@michael-jabbour-sonarsource
Copy link
Contributor

Now that the ARM64 scanner CLI is available, we can make the following changes in this PR:

  • Update the scanner version to 6.1
  • Use the aarch64 version on ARM64
  • No need to install a compatible JRE in the action anymore

Base automatically changed from vp/bwUsesCd to master June 30, 2024 19:10
@friedbyalice friedbyalice force-pushed the vp/supportLinux_ARM64 branch 2 times, most recently from c8c7365 to 4334289 Compare July 4, 2024 09:30
Copy link
Contributor

@michael-jabbour-sonarsource michael-jabbour-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I did some validation in the following runs:

@enzo-pellegrini Could you ask for a second review from AE for this as well?

@michael-jabbour-sonarsource
Copy link
Contributor

I think it would also make sense to release a new version of the action once this is merged, so that we can consume the new version in our onboarding examples...

@michael-jabbour-sonarsource
Copy link
Contributor

As a side note (not related to this PR), more of a question to the AE squad.

I noticed that the tests workflow isn't triggered on the master branch in this repo, because the workflow is enabled only on main (and there is no branch named main here as far as I can see). Is this intentional?

@7PH 7PH self-requested a review July 15, 2024 10:11
@7PH
Copy link
Contributor

7PH commented Jul 15, 2024

I noticed that the tests workflow isn't triggered on the master branch in this repo, because the workflow is enabled only on main (and there is no branch named main here as far as I can see). Is this intentional?

From a quick look, that should definitively run on the master branch (not main), I've created a ticket to track this, but otherwise feel free to fix this as part of the scope of this pull request.

@friedbyalice friedbyalice force-pushed the vp/supportLinux_ARM64 branch from 4334289 to 061a4f1 Compare July 15, 2024 10:38
Copy link
Contributor

@7PH 7PH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ No FV since @michael-jabbour-sonarsource reviewed it with FV

@friedbyalice friedbyalice merged commit 4aebde3 into master Jul 15, 2024
12 checks passed
@friedbyalice friedbyalice deleted the vp/supportLinux_ARM64 branch July 15, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants