NO-JIRA Fix build-wrapper download URL #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7PH
force-pushed
the
bugfix/br/fix-build-wrapper-url
branch
from
6595670 to
ab061ab
Compare
7PH
force-pushed
the
bugfix/br/fix-build-wrapper-url
branch
from
ab061ab to
4608ebb
Compare
7PH
force-pushed
the
bugfix/br/fix-build-wrapper-url
branch
from
4608ebb to
689905c
Compare
7PH
force-pushed
the
bugfix/br/fix-build-wrapper-url
branch
3 times, most recently
from
56aa5f2 to
0d8c0fb
Compare
7PH
requested review from
michael-jabbour-sonarsource
and removed request for
michael-jabbour-sonarsource
7PH
commented
Sep 12, 2024
michael-jabbour-sonarsource
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
I added one comment because I expected the required changeset to be smaller.
I don't have a strong opinion about it, so feel free to merge. The only argument I could think of is that the URL is expected to be shorter for most users, so I would prefer to keep internal tests without it...
7PH
force-pushed
the
bugfix/br/fix-build-wrapper-url
branch
from
0d8c0fb to
35510a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the obsolete URL to download the build wrapper