Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize ReadMe.md #218

Merged
merged 2 commits into from
May 17, 2024
Merged

Reorganize ReadMe.md #218

merged 2 commits into from
May 17, 2024

Conversation

pavel-mikula-sonarsource
Copy link
Contributor

Improve Getting started section
Bring Getting started from TL;DR; to a visible area
Remove some expired history context

Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly links to update

README.md Outdated

1. Roslyn analyzer authors
- Analyzer authors will be able to use the tools during development to provide additional metadata about their rules (e.g. SonarQube severity, tags, a richer description, ...) and generate the SonarQube plugin. See below for additional notes if you are developing your analyzer and running the SDK against the generated NuGet repeatedly on the same development machine.
The SDK is compatible with analyzer targeting Roslyn from version 1.0.0 up to the version specified in [Directory.Build.props](./Directory.Build.props#L9).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Directory.Build.props line is incorrect, it should the line 10:

Suggested change
The SDK is compatible with analyzer targeting Roslyn from version 1.0.0 up to the version specified in [Directory.Build.props](./Directory.Build.props#L9).
The SDK is compatible with analyzer targeting Roslyn from version 1.0.0 up to the version specified in [Directory.Build.props](./Directory.Build.props#L10).

If you want to create a jar for Roslyn analyzer that is not available from a NuGet feed (e.g. an analyzer you have created on your local machine) you can specify a package source that points at a local directory containing the *.nupkg* file created by the standard Roslyn templates. See the [NuGet docs](https://docs.nuget.org/create/hosting-your-own-nuget-feeds) for more information.

By default, the [NuGet.config](./RoslynPluginGenerator/NuGet.config#L16) file shipped with the RoslynSonarQubeGenerator has a local package source configured that points to `C:\LocalNugetFeed`.

#### NuGet packaging information
### NuGet packaging information
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link about the nuget properties documentation could be updated to: https://learn.microsoft.com/en-us/nuget/reference/nuspec#required-metadata-elements

The NuGet package properties are documented here...

As well as the SQ plugin properties documentation link, which contains a typo (the > at the end).


#### Generating a jar for an analyzer that is not available from a NuGet feed
### Generating a jar for an analyzer that is not available from a NuGet feed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, we can update the link to NuGet doc to host nuget to: https://learn.microsoft.com/en-us/nuget/hosting-packages/overview

See the NuGet docs for more information.


### Compatibility
v1.0 of the SDK generates plugins that are compatible with SonarQube v4.5.2 -> v6.7.
1. Download the latest [released version](./releases/latest), or clone and build this repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link here should be: https://github.com/SonarSource/sonarqube-roslyn-sdk/releases/latest.

Suggested change
1. Download the latest [released version](./releases/latest), or clone and build this repository.
1. Download the latest [released version](https://github.com/SonarSource/sonarqube-roslyn-sdk/releases/latest), or clone and build this repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will point to that page, once merged to master. I want to repo-independend for the future.

On GH "view page", it adds a commit ID in the way, because it's not in the root of the repo (yet)

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sebastien-marichal sebastien-marichal merged commit bacf199 into master May 17, 2024
2 checks passed
@sebastien-marichal sebastien-marichal deleted the Pavel/ReadMe branch May 17, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants