Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add webp support #105

Merged
merged 9 commits into from
Jul 8, 2023
Merged

Feature/add webp support #105

merged 9 commits into from
Jul 8, 2023

Conversation

BradLewis
Copy link
Member

Added support for webp. Needed to change our build into to golang:1.20-bullseye due to the following issue in the distroless images GoogleContainerTools/distroless#1342

@BradLewis BradLewis force-pushed the feature/add-webp-support branch 5 times, most recently from 3fa049e to dcfea1c Compare July 8, 2023 01:41
@BradLewis BradLewis force-pushed the feature/add-webp-support branch from dcfea1c to 32fd219 Compare July 8, 2023 01:42
@BradLewis BradLewis requested a review from TheDen July 8, 2023 01:43
Copy link
Member

@TheDen TheDen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add documentation about libwebp-dev dependency in README. Also potentially have a target in the makefile that adds it?

Dockerfile Outdated Show resolved Hide resolved
@TheDen TheDen self-requested a review July 8, 2023 15:02
Copy link
Member

@TheDen TheDen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@BradLewis BradLewis merged commit c3c7c34 into main Jul 8, 2023
@BradLewis BradLewis deleted the feature/add-webp-support branch July 8, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants