Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extraction code failure by updating it for archiver 2.0 API #4

Merged
merged 1 commit into from
Dec 15, 2016
Merged

Fix extraction code failure by updating it for archiver 2.0 API #4

merged 1 commit into from
Dec 15, 2016

Conversation

BlueSkyDetector
Copy link
Contributor

@BlueSkyDetector BlueSkyDetector commented Dec 14, 2016 •
edited
Loading

When I try to install ghg, I got following error.

$ go get github.com/Songmu/ghg/cmd/ghg
# github.com/Songmu/ghg
../go/src/github.com/Songmu/ghg/ghg.go:180: undefined: archiver.Unzip
../go/src/github.com/Songmu/ghg/ghg.go:183: undefined: archiver.UntarGz

It looks because of the "mholt/archiver" API changed in 2.0.
https://github.com/mholt/archiver/releases/tag/v2.0

This PR is fix for #5.

@Songmu
Copy link
Owner

Songmu commented Dec 15, 2016

Thank you!

@Songmu Songmu merged commit 52cb139 into Songmu:master Dec 15, 2016
@BlueSkyDetector
Copy link
Contributor Author

Thank you.
It becomes a good chance for my first PR in golang :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BlueSkyDetector @Songmu