Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Even if - is specified for tagpr.versionFile, version files will be detected #144

Closed
toritori0318 opened this issue Jan 18, 2023 · 5 comments
Closed

Even if - is specified for tagpr.versionFile, version files will be detected #144

toritori0318 opened this issue Jan 18, 2023 · 5 comments

Comments

@toritori0318
Copy link
Contributor

Hi @Songmu.

It is written in this way in the README.

tagpr.versionFile

'If you do not want to use versioning files but only git tags, specify the "-" string here. '

I have specified -, but the version_file is detected.
Probably detecting files acquired here.

Is this the intended behavior?
Thanks.
@Songmu
Copy link
Owner

Songmu commented Jan 18, 2023

Oops. This is unintended behavior.

@toritori0318
Copy link
Contributor Author

Thank you for the quick reply!

Perhaps stop trimming the - here in stringify, and change here to else if tp.cfg.VersionFile() ! = "-".

If it is not already supported, shall we support it?

@Songmu
Copy link
Owner

Songmu commented Jan 18, 2023

Yes, this should be supported. Since we would like to limit version file detection to only the first run.

@toritori0318
Copy link
Contributor Author

toritori0318 commented Jan 18, 2023 •
edited
Loading

OK, Now I will prepare the PR...

@toritori0318 toritori0318 mentioned this issue Jan 18, 2023
Merged
@toritori0318
Copy link
Contributor Author

We re-ran the latest version at our service and confirmed that it works as intended! 🎉

Thanks for a great tool!

@toritori0318 toritori0318 mentioned this issue Jan 20, 2023
Closed
toritori0318 added a commit to toritori0318/tagpr that referenced this issue Jan 20, 2023
@toritori0318
fix: Bug fixes related to Songmu#144
e264b41
Songmu added a commit that referenced this issue Jan 20, 2023
@Songmu
Merge pull request #148 from toritori0318/issue-145-fix
03e0453 
fix: Bug fixes related to #144
Merged
@Songmu Songmu closed this as completed Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@toritori0318 @Songmu