Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider vPrefix when retrieving the latest semver tag. #159

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

k1LoW
Copy link
Contributor

@k1LoW k1LoW commented Oct 18, 2023

Hi @Songmu.

I am currently operating a repository with a mix of "semver with v prefix" and "calver without v prefix".

$ gh release list | cut -f 1
v1.1.2
v1.1.1
2023.05.1
2023.05.0
v1.1.0
v1.0.1
2023.03.1
2023.03.0
v1.0.0
2023.02.0
v0.1.0

At this time, tagpr may misidentify calver as semver.

If tagpr could determine the vPrefix setting more strictly, it would avoid the misidentification, at least in my environment.

I hope you will consider this change.

@Songmu Songmu merged commit 4f96684 into Songmu:main Oct 18, 2023
3 checks passed
@k1LoW
Copy link
Contributor Author

k1LoW commented Oct 18, 2023

Thanks for the quick merge!

@k1LoW k1LoW deleted the consider-v-prefix branch October 18, 2023 03:01
@k1LoW
Copy link
Contributor Author

k1LoW commented Oct 18, 2023

@Songmu
Thank you. It works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants