feat: Add flag to turn on or off creating/modifying CHANGELOG.md #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. It is a good feature.
|
siketyan
commented
Sep 6, 2022
| logs, _, err := gch.Changelogs(ctx, 20) | ||
| if err != nil { | ||
|
|
||
| if tp.cfg.changelog == nil || *tp.cfg.changelog { |
There was a problem hiding this comment.
@Songmu If tagpr.changelog configuration is not defined, this condition will be evaluated to true, isn't it? So it does not change the current behaviour.
There was a problem hiding this comment.
Oops. You are right. So here's what you should do.
- Update
cfg.Reload - Keep .tagpr unchagend in this repository
|
Great! Thank you. |
Merged
|
Released as v0.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since our project is not using CHANGELOG.md, creating or modifying them by tagpr is not needed for us. This pull request proposes to add a flag to turn on/off the feature by .tagpr configuration file for people who wants turn it off like us.