変なカレンダー生成プログラムの作成（レベル3） #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkitoShiga
commented
Dec 8, 2024
lib/sg_strange_calendar.rb
Outdated
Comment on lines
119
to
134
| def vertical_emphasized_line(line) | ||
| line.map do |space| | ||
| case space | ||
| when /\[\d{2}\]/ | ||
| space | ||
| when /\[\d{1}\]/ | ||
| ' ' + space | ||
| else | ||
| space + ' ' | ||
| end | ||
| end.join | ||
| end | ||
|
|
||
| def horizontal_emphasized_line(line) | ||
| line.join(' ') | ||
| .sub(/(?<=\[\d{1}\]) {1}/, '') | ||
| .gsub(/ {1}(?=\[\d{2}\])/,'') | ||
| .gsub(/((?<=\[\d{2}\]) {1})/, '') |
There was a problem hiding this comment.
この辺り良い解法が思いつかず、正規表現でのパワープレイ気味な実装になってしまいました...🙏
|
@AkitoShigaさん |
|
@JunichiIto さん |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
自分が解いたレベル（レベル1~3）
レベル3
コードのアピールポイント
読んだ時にその動作がわかりやすいコードを目指しました
コードを書くのにかかった時間
テストケースを通すのに5時間 + リファクタで2.5時間
だいたいのプログラミング歴
5年
実際に解いてみた感想
このような問題を解くプラグラミングは長らく行っていなかったので、ものすごく楽しかったです！時間が一瞬で溶ける感覚を久々に味わいました。
伊藤さんにメッセージ
伊藤さん初めまして！しがと申します。
このような機会を頂けて嬉しいです！
厳しめなレビューをお願いします🙏