Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmmk: support VIA #147

Merged
merged 2 commits into from
Nov 21, 2021
Merged

gmmk: support VIA #147

merged 2 commits into from
Nov 21, 2021

Conversation

gloryhzw
Copy link

Description

  1. Support VIA keymap
  2. Optimize rev2 I2C

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

1. Support VIA keymap
2. Optimize rev2 I2C
@dexter93 dexter93 added this to the Sonix November 2021 Merge milestone Nov 18, 2021
@dexter93 dexter93 merged commit 566c7d8 into SonixQMK:sn32 Nov 21, 2021
@DaoWen
Copy link

DaoWen commented Dec 14, 2021

@gloryhzw - Does VIA software work for you after flashing the "via" firmware you merged here? I'm just curious because I tried flashing it to my GMMK Full Rev3, and VIA refused to detect my device.

Regardless, the updates to the keymaps and other changes you made were very helpful to me. I don't mind running qmk locally, so not having VIA isn't a big deal. After a few iterations and using your patch as an example, I was finally able to get my GMMK configured with the hotkey bindings and RGB_MATRIX_SOLID_REACTIVE LED scheme that I wanted.

TL;DR — Thanks for contributing this patch!

EDIT: Talked to @gloryhzw on discord, and it turns out that I just needed to load the keymap json into VIA, and then it picked it up my device right away. 🤦‍♂️

@gloryhzw
Copy link
Author

gloryhzw commented Dec 15, 2021 via email

@guilleortas
Copy link

I'm getting a segfault error when trying to build any of the variants listed in the readme of the GMMK 1 full-size.
I'm using a clean install of QMK MSYS, I can't tell what's going on and I'd really like to build this firmware

@gloryhzw
Copy link
Author

Try to use the latest qmk msys 1.7.1

@guilleortas
Copy link

I'm sorry for my blunt message, I'd like to really thank the SonixQMK project for the amazing work you're doing, it's such a powerful resource.
I was already using v1.7.1, and I have tried a clean install on a different computer but the problem is still there. Does it compile for you?

@guilleortas
Copy link

To update on this matter, removing a few folders you don't need from the keyboards directory seems to do the trick: This is connected to stack size, see this issue for more insight.

@gloryhzw
Copy link
Author

gloryhzw commented Oct 11, 2022 via email

BestPig pushed a commit to BestPig/qmk_firmware that referenced this pull request Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants