Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT authentication #239

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

alexeyramazanov
Copy link

As it's written - JWT support for sorcery.

Partially based on #70 and #167.

Copy link

@sqlninja sqlninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As someone that is currently utilizing https://github.com/hayfever/sorcery-jwt for tokens, I would love to see this move forward. I currently have a snag with the mentioned gem and oauth. When a user logs in with a provider (i.e. Twitter), I am not getting a token. I suspect JWT being "baked" into Sorcery would allow for that...

@joshbuker
Copy link
Member

@sqlninja I'm about to look into this for Sorcery v1, one thing that I would like to know is if the community would prefer this to be a part of sorcery-core, or keep this as a plugin you can add sorcery-jwt. I'm leaning towards the latter, seeing as most applications don't need JWT.

To @alexeyramazanov, @hayfever, @wilddima, @ebihara99999: would any of you be willing to assist me in implementing this in Sorcery v1? Being pointed at the right documentation for JWT, as well as having the perspective of someone who already uses it would both be incredibly helpful for me. Whatever we design, I want to ensure it is interoperable with other plugins (e.g. sorcery-oauth).

@joshbuker joshbuker added the to be implemented in v1 This issue or pull request will be resolved in the v1 rework, but has not yet been completed. label Apr 5, 2021
@hayfever
Copy link

hayfever commented Apr 5, 2021

I would agree that a plugin seems to make the most sense - I enjoy the modularity of sorcery even if a lot of the plugins end up getting used as "defaults".

I would definitely be willing to help where needed - I will say that I haven't been using my extension for quite a while as I had written it solely to authenticate a mobile app in a previous project I was working on. The project I'm now working on (unfortunately) uses devise so I've been out of the sorcery world for a little while, too.

@joshbuker
Copy link
Member

I created a new issue on the rework repo for discussing the JWT implementation, anyone who wants to help is welcome to comment there: Sorcery/sorcery-rework#9

@joshbuker joshbuker added implemented in v1 This issue or pull request has been resolved in the v1 rework codebase and removed to be implemented in v1 This issue or pull request will be resolved in the v1 rework, but has not yet been completed. labels May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implemented in v1 This issue or pull request has been resolved in the v1 rework codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants