Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apple as oauth provider #344

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nduitz
Copy link

@nduitz nduitz commented Apr 20, 2023

Hey, tried adding this apple adapter.

The apple flow is a bit different compared to other implementations:

  • Apple expects a nonce, that can later be verified
  • The secret is not a predefined key but a JWT token containing the team_id, issuer, package_name, private_key_id and issue/expiry timestamps. The JWT has to be signed by a private key provided by apple.
  • Apple has no 'user_info' callback. Instead they include an jwt token in the response containing the user info defined via scope. The JWT can be veryfied by querying /auth/keys to find the current keys used for signing (the JWT header contains the kid which is used to identified the correct key). This is optional by configuring verify_payload: true.

Would appreciate some feedback :)

@nduitz nduitz force-pushed the feature/apple-oauth branch 3 times, most recently from ffef7a4 to 902a050 Compare April 20, 2023 12:18
@nduitz nduitz force-pushed the feature/apple-oauth branch 2 times, most recently from 509d5ed to fa3a1f3 Compare September 4, 2023 10:51
@joshbuker joshbuker added the enhancement New feature or request label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants