Fix rubocop RSpec offenses

.rubocop_todo.yml

@@ -19,55 +19,10 @@ RSpec/AnyInstance:
     - 'spec/controllers/controller_oauth2_spec.rb'
     - 'spec/shared_examples/user_shared_examples.rb'
 
-# Offense count: 19
-# This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/BeEq:
-  Exclude:
-    - 'spec/shared_examples/user_activity_logging_shared_examples.rb'
-    - 'spec/shared_examples/user_magic_login_shared_examples.rb'
-    - 'spec/shared_examples/user_remember_me_shared_examples.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/BeEql:
-  Exclude:
-    - 'spec/shared_examples/user_activation_shared_examples.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: be, be_nil
-RSpec/BeNil:
-  Exclude:
-    - 'spec/shared_examples/user_shared_examples.rb'
-
 # Offense count: 66
 RSpec/BeforeAfterAll:
   Enabled: false
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/ContextMethod:
-  Exclude:
-    - 'spec/shared_examples/user_brute_force_protection_shared_examples.rb'
-
-# Offense count: 35
-# Configuration parameters: Prefixes, AllowedPatterns.
-# Prefixes: when, with, without
-RSpec/ContextWording:
-  Exclude:
-    - 'spec/providers/example_provider_spec.rb'
-    - 'spec/providers/example_spec.rb'
-    - 'spec/providers/examples_spec.rb'
-    - 'spec/providers/vk_spec.rb'
-    - 'spec/shared_examples/user_activation_shared_examples.rb'
-    - 'spec/shared_examples/user_activity_logging_shared_examples.rb'
-    - 'spec/shared_examples/user_brute_force_protection_shared_examples.rb'
-    - 'spec/shared_examples/user_magic_login_shared_examples.rb'
-    - 'spec/shared_examples/user_reset_password_shared_examples.rb'
-    - 'spec/shared_examples/user_shared_examples.rb'
-    - 'spec/sorcery_temporary_token_spec.rb'
-
 # Offense count: 1
 # Configuration parameters: IgnoredMetadata.
 RSpec/DescribeClass:
@@ -91,33 +46,6 @@ RSpec/DescribeMethod:
     - 'spec/active_record/user_reset_password_spec.rb'
     - 'spec/active_record/user_spec.rb'
 
-# Offense count: 70
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: SkipBlocks, EnforcedStyle, OnlyStaticConstants.
-# SupportedStyles: described_class, explicit
-RSpec/DescribedClass:
-  Exclude:
-    - 'spec/active_record/user_activation_spec.rb'
-    - 'spec/active_record/user_activity_logging_spec.rb'
-    - 'spec/active_record/user_brute_force_protection_spec.rb'
-    - 'spec/active_record/user_magic_login_spec.rb'
-    - 'spec/active_record/user_oauth_spec.rb'
-    - 'spec/active_record/user_remember_me_spec.rb'
-    - 'spec/active_record/user_reset_password_spec.rb'
-    - 'spec/active_record/user_spec.rb'
-    - 'spec/providers/example_provider_spec.rb'
-    - 'spec/providers/example_spec.rb'
-    - 'spec/providers/examples_spec.rb'
-    - 'spec/sorcery_crypto_providers_spec.rb'
-    - 'spec/sorcery_temporary_token_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowConsecutiveOneLiners.
-RSpec/EmptyLineAfterHook:
-  Exclude:
-    - 'spec/controllers/controller_oauth2_spec.rb'
-
 # Offense count: 59
 # Configuration parameters: Max, CountAsOne.
 RSpec/ExampleLength:
@@ -136,69 +64,11 @@ RSpec/ExampleLength:
     - 'spec/shared_examples/user_reset_password_shared_examples.rb'
     - 'spec/shared_examples/user_shared_examples.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: CustomTransform, IgnoredWords, DisallowedExamples.
-# DisallowedExamples: works
-RSpec/ExampleWording:
-  Exclude:
-    - 'spec/providers/vk_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/ExcessiveDocstringSpacing:
-  Exclude:
-    - 'spec/shared_examples/user_magic_login_shared_examples.rb'
-
-# Offense count: 3
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: method_call, block
-RSpec/ExpectChange:
-  Exclude:
-    - 'spec/shared_examples/user_shared_examples.rb'
-
 # Offense count: 2
 RSpec/ExpectInHook:
   Exclude:
     - 'spec/controllers/controller_spec.rb'
 
-# Offense count: 50
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: implicit, each, example
-RSpec/HookArgument:
-  Exclude:
-    - 'spec/controllers/controller_activity_logging_spec.rb'
-    - 'spec/controllers/controller_http_basic_auth_spec.rb'
-    - 'spec/controllers/controller_oauth2_spec.rb'
-    - 'spec/controllers/controller_oauth_spec.rb'
-    - 'spec/controllers/controller_session_timeout_spec.rb'
-    - 'spec/controllers/controller_spec.rb'
-    - 'spec/shared_examples/user_activation_shared_examples.rb'
-    - 'spec/shared_examples/user_activity_logging_shared_examples.rb'
-    - 'spec/shared_examples/user_brute_force_protection_shared_examples.rb'
-    - 'spec/shared_examples/user_magic_login_shared_examples.rb'
-    - 'spec/shared_examples/user_remember_me_shared_examples.rb'
-    - 'spec/shared_examples/user_reset_password_shared_examples.rb'
-    - 'spec/shared_examples/user_shared_examples.rb'
-    - 'spec/sorcery_crypto_providers_spec.rb'
-    - 'spec/spec_helper.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/HooksBeforeExamples:
-  Exclude:
-    - 'spec/controllers/controller_oauth2_spec.rb'
-
-# Offense count: 6
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: is_expected, should
-RSpec/ImplicitExpect:
-  Exclude:
-    - 'spec/controllers/controller_spec.rb'
-
 # Offense count: 72
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
@@ -210,26 +80,6 @@ RSpec/InstanceVariable:
     - 'spec/shared_examples/user_shared_examples.rb'
     - 'spec/sorcery_crypto_providers_spec.rb'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: it_behaves_like, it_should_behave_like
-RSpec/ItBehavesLike:
-  Exclude:
-    - 'spec/active_record/user_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/LeadingSubject:
-  Exclude:
-    - 'spec/sorcery_temporary_token_spec.rb'
-
-# Offense count: 4
-RSpec/LeakyConstantDeclaration:
-  Exclude:
-    - 'spec/shared_examples/user_magic_login_shared_examples.rb'
-    - 'spec/shared_examples/user_shared_examples.rb'
-
 # Offense count: 1
 RSpec/MessageChain:
   Exclude:
@@ -241,23 +91,6 @@ RSpec/MessageChain:
 RSpec/MessageSpies:
   EnforcedStyle: receive
 
-# Offense count: 10
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: hash, symbol
-RSpec/MetadataStyle:
-  Exclude:
-    - 'spec/active_record/user_activation_spec.rb'
-    - 'spec/active_record/user_activity_logging_spec.rb'
-    - 'spec/active_record/user_brute_force_protection_spec.rb'
-    - 'spec/active_record/user_magic_login_spec.rb'
-    - 'spec/active_record/user_oauth_spec.rb'
-    - 'spec/active_record/user_remember_me_spec.rb'
-    - 'spec/active_record/user_reset_password_spec.rb'
-    - 'spec/active_record/user_spec.rb'
-    - 'spec/controllers/controller_oauth2_spec.rb'
-    - 'spec/shared_examples/user_shared_examples.rb'
-
 # Offense count: 104
 # Configuration parameters: Max.
 RSpec/MultipleExpectations:
@@ -295,35 +128,6 @@ RSpec/NestedGroups:
     - 'spec/shared_examples/user_magic_login_shared_examples.rb'
     - 'spec/shared_examples/user_shared_examples.rb'
 
-# Offense count: 6
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: not_to, to_not
-RSpec/NotToNot:
-  Exclude:
-    - 'spec/shared_examples/user_activation_shared_examples.rb'
-    - 'spec/shared_examples/user_remember_me_shared_examples.rb'
-    - 'spec/shared_examples/user_reset_password_shared_examples.rb'
-
-# Offense count: 7
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/ReceiveNever:
-  Exclude:
-    - 'spec/controllers/controller_oauth2_spec.rb'
-    - 'spec/controllers/controller_oauth_spec.rb'
-    - 'spec/shared_examples/user_activation_shared_examples.rb'
-    - 'spec/shared_examples/user_reset_password_shared_examples.rb'
-
-# Offense count: 6
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: and_return, block
-RSpec/ReturnFromStub:
-  Exclude:
-    - 'spec/controllers/controller_oauth2_spec.rb'
-    - 'spec/controllers/controller_session_timeout_spec.rb'
-    - 'spec/shared_examples/user_shared_examples.rb'
-
 # Offense count: 21
 # Configuration parameters: CustomTransform, IgnoreMethods, IgnoreMetadata.
 RSpec/SpecFilePathFormat:
@@ -339,27 +143,13 @@ RSpec/StubbedMock:
     - 'spec/controllers/controller_spec.rb'
     - 'spec/shared_examples/user_shared_examples.rb'
 
-# Offense count: 1
-RSpec/SubjectStub:
-  Exclude:
-    - 'spec/controllers/controller_session_timeout_spec.rb'
-
 # Offense count: 3
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Exclude:
     - 'spec/controllers/controller_oauth2_spec.rb'
     - 'spec/shared_examples/user_shared_examples.rb'
 
-# Offense count: 6
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/Yield:
-  Exclude:
-    - 'spec/controllers/controller_brute_force_protection_spec.rb'
-    - 'spec/controllers/controller_remember_me_spec.rb'
-    - 'spec/controllers/controller_session_timeout_spec.rb'
-    - 'spec/controllers/controller_spec.rb'
-
 # Offense count: 126
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.

spec/active_record/user_activation_spec.rb

@@ -3,10 +3,10 @@
 require 'rails_app/app/mailers/sorcery_mailer'
 require 'shared_examples/user_activation_shared_examples'
 
-describe User, 'with activation submodule', active_record: true do
+describe User, 'with activation submodule', :active_record do
   before(:all) do
     MigrationHelper.migrate("#{Rails.root}/db/migrate/activation")
-    User.reset_column_information
+    described_class.reset_column_information
   end
 
   after(:all) do

spec/active_record/user_activity_logging_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 require 'shared_examples/user_activity_logging_shared_examples'
 
-describe User, 'with activity logging submodule', active_record: true do
+describe User, 'with activity logging submodule', :active_record do
   before(:all) do
     MigrationHelper.migrate("#{Rails.root}/db/migrate/activity_logging")
-    User.reset_column_information
+    described_class.reset_column_information
   end
 
   after(:all) do

spec/active_record/user_brute_force_protection_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 require 'shared_examples/user_brute_force_protection_shared_examples'
 
-describe User, 'with brute_force_protection submodule', active_record: true do
+describe User, 'with brute_force_protection submodule', :active_record do
   before(:all) do
     MigrationHelper.migrate("#{Rails.root}/db/migrate/brute_force_protection")
-    User.reset_column_information
+    described_class.reset_column_information
   end
 
   after(:all) do

spec/active_record/user_magic_login_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 require 'shared_examples/user_magic_login_shared_examples'
 
-describe User, 'with magic_login submodule', active_record: true do
+describe User, 'with magic_login submodule', :active_record do
   before(:all) do
     MigrationHelper.migrate("#{Rails.root}/db/migrate/magic_login")
-    User.reset_column_information
+    described_class.reset_column_information
   end
 
   after(:all) do

spec/active_record/user_oauth_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 require 'shared_examples/user_oauth_shared_examples'
 
-describe User, 'with oauth submodule', active_record: true do
+describe User, 'with oauth submodule', :active_record do
   before(:all) do
     MigrationHelper.migrate("#{Rails.root}/db/migrate/external")
-    User.reset_column_information
+    described_class.reset_column_information
   end
 
   after(:all) do

spec/active_record/user_remember_me_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 require 'shared_examples/user_remember_me_shared_examples'
 
-describe User, 'with remember_me submodule', active_record: true do
+describe User, 'with remember_me submodule', :active_record do
   before(:all) do
     MigrationHelper.migrate("#{Rails.root}/db/migrate/remember_me")
-    User.reset_column_information
+    described_class.reset_column_information
   end
 
   after(:all) do

spec/active_record/user_reset_password_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 require 'shared_examples/user_reset_password_shared_examples'
 
-describe User, 'with reset_password submodule', active_record: true do
+describe User, 'with reset_password submodule', :active_record do
   before(:all) do
     MigrationHelper.migrate("#{Rails.root}/db/migrate/reset_password")
-    User.reset_column_information
+    described_class.reset_column_information
   end
 
   after(:all) do

spec/active_record/user_spec.rb

@@ -2,7 +2,7 @@
 require 'rails_app/app/mailers/sorcery_mailer'
 require 'shared_examples/user_shared_examples'
 
-describe User, 'with no submodules (core)', active_record: true do
+describe User, 'with no submodules (core)', :active_record do
   before(:all) do
     sorcery_reload!
   end
@@ -13,15 +13,15 @@
     end
 
     it 'User responds to .authenticates_with_sorcery!' do
-      expect(User).to respond_to :authenticates_with_sorcery!
+      expect(described_class).to respond_to :authenticates_with_sorcery!
     end
   end
 
   # ----------------- PLUGIN CONFIGURATION -----------------------
 
-  it_should_behave_like 'rails_3_core_model'
+  it_behaves_like 'rails_3_core_model'
 
   describe 'external users' do
-    it_should_behave_like 'external_user'
+    it_behaves_like 'external_user'
   end
 end