Skip to content
This repository has been archived by the owner on Aug 10, 2023. It is now read-only.

Homepage #33

Merged
merged 45 commits into from
Aug 7, 2017
Merged

Homepage #33

merged 45 commits into from
Aug 7, 2017

Conversation

Soreine
Copy link
Owner

@Soreine Soreine commented Aug 6, 2017

@Soreine
Copy link
Owner Author

Soreine commented Aug 6, 2017

Missing a favicon (the icon of the extension)

@Soreine
Copy link
Owner Author

Soreine commented Aug 6, 2017

Close #11

Copy link
Collaborator

@zhouzi zhouzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

"name": "Hyper Gwent",
"description": "Enrich pages containing GwentⓇ related content. Card names quick access, terms highlight and more!",
"description": "Show tooltips for cards in pages containing GwentⓇ related content.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that's an issue but this description is different than the one on the website.

@@ -1,19 +1,22 @@
{
"manifest_version": 2,
"author": "Soreine & Zhouzi",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

<p className="issues">
If you find bugs, if you want to submit new acronyms, request a feature, or contribute, post an issue <a href={REPO}>here</a>.
<br/>
You can also contact <a href="https://www.reddit.com/message/compose/?to=Soreine">/u/Soreine</a>.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could customize the HTML template to include all this, it'd be better for SEO & all. The Webpack loader would just insert the JavaScript specific code.

@zhouzi zhouzi merged commit 43a4710 into master Aug 7, 2017
@zhouzi zhouzi deleted the homepage branch August 7, 2017 11:49
@zhouzi zhouzi mentioned this pull request Aug 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants