Specify sortablejs as a peer dependency #148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a breaking change, as users may not have sortablejs installed locally. This might be alright nonetheless. reminder to self: bump up major version, use ci to run tests on sortable version bump. I need to run some tests locally to ensure this works fine. |
github-actions bot
pushed a commit
to kha333n/react-sortablejs
that referenced
this pull request
Nov 15, 2024
# 1.0.0 (2024-11-15) ### Bug Fixes * **react-sortable.jsx:** const newList = [...props.list].map((item) => ([c945c6d](c945c6d)) * allow update disabled prop at runtime ([dccdd24](dccdd24)) * fix package versions ([b464971](b464971)) * infra ([1d43f97](1d43f97)) * object-assign errors ([fde561e](fde561e)) * passes clone function to onAdd if cloning ([SortableJS#173](https://github.com/kha333n/react-sortablejs/issues/173)) ([5ff3f4a](5ff3f4a)) * preserve original objects ([362cbd5](362cbd5)) * update dependencies ([b8ca5c2](b8ca5c2)) * update dependencies ([8401a8c](8401a8c)) * **react18:** add `children` to `ReactSortableProps` ([f6b4e2e](f6b4e2e)) * spell 'these' incorrectly ([0656825](0656825)) * **ci:** adds dist/** to git assets ([c46913f](c46913f)) * **remove unnecesary devdependencies:** rmeove innecesary devDependencies ([1000f68](1000f68)) * **semantic:** adds missing github plugin ([f6a7cca](f6a7cca)) * **semantic:** use dist/** glob ([76d1ba0](76d1ba0)) * **semantic:** uses dist/**.* to assets ([6aa4183](6aa4183)) * **types:** removes MultiDrag and Swap exports from index ([f34c861](f34c861)), closes [SortableJS#179](https://github.com/kha333n/react-sortablejs/issues/179) * **util.ts:** changes custom type Omit to extend keyof T ([9db7297](9db7297)) ### Build System * **parcel:** replace rollup with parcel 2 ([3876be2](3876be2)) ### Code Refactoring * help ([1cb872e](1cb872e)) ### Continuous Integration * **semantic:** adds plugin @semantic/git ([5f2b28e](5f2b28e)) ### Documentation * ensure sortablejs and @types/sortablejs are peers dependencies ([1686019](1686019)) ### Features * remove and update dependencies ([65fa886](65fa886)) * **deps:** adds sortablejs and @types/sortablejs as peer dependencies ([d8c2ce4](d8c2ce4)), closes [SortableJS#148](https://github.com/kha333n/react-sortablejs/issues/148) * **deps:** adds sortablejs and @types/sortablejs as peer dependencies ([07da8b9](07da8b9)), closes [SortableJS#148](https://github.com/kha333n/react-sortablejs/issues/148) ### Reverts * prettier preserve semicolons ([a658d04](a658d04)) ### BREAKING CHANGES * **parcel:** packagejson#module was removed because the file is no longer being generated. * **types:** it's apparent we're import sortablejs with all plugins mounted. We've had a few bugs come in that MultiDrag no longer exports because of version 1.12.x of sortablejs making an accidental breaking change. * **semantic:** pushes the changes to the git repository * please, build for me * peer dependencies now required * **deps:** Users want to use their own versions of sortablejs, so we'll allow it. * **deps:** Users want to use their own versions of sortablejs, so we'll allow it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are potentially situations where users may need certain modifications made to sortablejs that are not part of its release candidate. I'm setting sortablejs as a peer dependency in order to allow me to set forked versions of sortablejs while continuing to leverage the awesome work you've done here with react-sortablejs.
Let me know if there is anything else you need to make this happen.