Fix failed to execute 'removeChild' on 'Node', #55 #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheton
approved these changes
Feb 18, 2019
Collaborator
cheton
left a comment
cheton
left a comment
There was a problem hiding this comment.
It would definitely help. Thank you!
ultralabed
deleted the
bugfix/Issue-55-Failed-execute-removeChild-on-Node
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix aims at Issue 55
Problem:
The
uncontrolled componentis going tomanipulate the DOM, andincorrect react-fiber treewas made when it doesvirtual dom diff. Finally, when react-dom try to react to manipulate the DOM, it will fail.Solution:
Use
shouldComponentUpdatelifecycle to prevent uncontrolled component to re-render.