Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failed to execute 'removeChild' on 'Node', #55 #59

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Fix failed to execute 'removeChild' on 'Node', #55 #59

merged 1 commit into from
Feb 18, 2019

Conversation

ultralabed
Copy link
Collaborator

@ultralabed ultralabed commented Feb 18, 2019 •
edited
Loading

This fix aims at Issue 55

Problem:
The uncontrolled component is going to manipulate the DOM, and incorrect react-fiber tree was made when it does virtual dom diff. Finally, when react-dom try to react to manipulate the DOM, it will fail.

Solution:
Use shouldComponentUpdate lifecycle to prevent uncontrolled component to re-render.

@ultralabed ultralabed self-assigned this Feb 18, 2019
@ultralabed ultralabed requested a review from cheton February 18, 2019 15:34
cheton
cheton approved these changes Feb 18, 2019
View reviewed changes
Copy link
Collaborator

@cheton cheton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would definitely help. Thank you!

@ultralabed ultralabed merged commit f21ed7f into SortableJS:master Feb 18, 2019
@ultralabed ultralabed deleted the bugfix/Issue-55-Failed-execute-removeChild-on-Node branch February 18, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheton cheton cheton approved these changes

Assignees

@ultralabed ultralabed

Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ultralabed @cheton @trend-edward-shih