DIA-2621 add usnat to /meta-data
#508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilveirah
requested review from
Nevazhnovu,
carmelo-iriti and
bohdan-go-wombat
Nevazhnovu
reviewed
Nov 2, 2023
Nevazhnovu
reviewed
Nov 2, 2023
ConsentViewController/Classes/SourcePointClient/MetaDataRequestResponse.swift
Outdated
Show resolved
Hide resolved
Nevazhnovu
reviewed
Nov 2, 2023
| @@ -503,5 +503,33 @@ class SPClientCoordinatorSpec: QuickSpec { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // TODO: remove fdescribe | |||
| fdescribe("a property with USNat campaign") { | |||
There was a problem hiding this comment.
FYI f in fdescribe might be a typo, pls double check
There was a problem hiding this comment.
Also, remove the comment pls
There was a problem hiding this comment.
I placed this comments on purpose, because unfortunately we have to skip a lot of tests in order to run them while pointing the SDK to stage. The SDK rely on ids that are only available in prod. Those TODOs will remind us to bring the tests back before merging to develop.
carmelo-iriti
approved these changes
Nov 3, 2023
andresilveirah
force-pushed
the
DIA-2030_add_support_to_usnat
branch
from
17c2f66 to
84ccb68
Compare
andresilveirah
force-pushed
the
DIA_2621_add_usnat_to_metadata
branch
from
6395cb1 to
8bb63cb
Compare
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USNatCampaignSPUSNatConsentSPUserDatato containSPUSNatConsent/meta-datarequest/response to containusnat/meta-datawhen calling response.loadMessagesSPCoordinatorregarding USNat/meta-dataSince usnat is only available on stage and many tests rely on ids present only on prod, several tests were skipped. Only the ones related to the feature will run. We'll revert that back when usnat is in preprod and we're close to merge to develop.