DIA-2622 add usnat to /messages
#513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilveirah
changed the base branch from
develop
to
DIA-2030_add_support_to_usnat
andresilveirah
commented
Nov 6, 2023
| state.ccpa?.webConsentPayload = $0.webConsentPayload | ||
| state.ccpa?.GPPData = consents.GPPData | ||
| default: break | ||
| } |
There was a problem hiding this comment.
The logic above moved to each of the consent classes convenience methods.
15 tasks
andresilveirah
requested review from
Nevazhnovu,
carmelo-iriti and
bohdan-go-wombat
Nevazhnovu
reviewed
Nov 6, 2023
ConsentViewController/Classes/SourcePointClient/MessagesRequest.swift
Outdated
Show resolved
Hide resolved
Example/ConsentViewController_ExampleTests/Helpers/CustomMatchers.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CampaignConsentandLastMessageDatato their own files/messagesresponse moving the logic to convenience inits ofSPCCPAConsent,SPGDPRConsentand (newly created)SPUSNatConsentSPDatesin a more convenient waySPUSNatConsentwith more consent data attributesusnatcampaign typeusnatto/messagesrequest and responsestate.usnaton/messages' response